codecov-api icon indicating copy to clipboard operation
codecov-api copied to clipboard

bundle analysis: assets can fetch true gzip size

Open JerrySentry opened this issue 1 year ago • 4 comments

closes https://github.com/codecov/engineering-team/issues/1928

Fetch the actual asset gzip size from the bundle report instead of guessing its value. Also refactor the BundleData object a bit, so that it can be deleted soon because we won't need it.

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

JerrySentry avatar Jun 26 '24 20:06 JerrySentry

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 91.55%. Comparing base (7a2b8df) to head (ef09a60).

:white_check_mark: All tests successful. No failed tests found.

@@           Coverage Diff           @@
##             main     #642   +/-   ##
=======================================
  Coverage   91.54%   91.55%           
=======================================
  Files         621      621           
  Lines       16555    16569   +14     
=======================================
+ Hits        15156    15170   +14     
  Misses       1399     1399           
Flag Coverage Δ
unit 91.55% <100.00%> (+<0.01%) :arrow_up:
unit-latest-uploader 91.55% <100.00%> (+<0.01%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
graphql_api/types/bundle_analysis/base.py 100.00% <100.00%> (ø)
graphql_api/types/bundle_analysis/comparison.py 100.00% <100.00%> (ø)
graphql_api/types/bundle_analysis/report.py 100.00% <100.00%> (ø)
services/bundle_analysis.py 100.00% <100.00%> (ø)

:mega: Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

codecov-qa[bot] avatar Jun 26 '24 20:06 codecov-qa[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 91.55%. Comparing base (7a2b8df) to head (ef09a60). Report is 56 commits behind head on main.

:white_check_mark: All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #642   +/-   ##
=======================================
  Coverage   91.54%   91.55%           
=======================================
  Files         621      621           
  Lines       16555    16569   +14     
=======================================
+ Hits        15156    15170   +14     
  Misses       1399     1399           
Flag Coverage Δ
unit 91.55% <100.00%> (+<0.01%) :arrow_up:
unit-latest-uploader 91.55% <100.00%> (+<0.01%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
graphql_api/types/bundle_analysis/base.py 100.00% <100.00%> (ø)
graphql_api/types/bundle_analysis/comparison.py 100.00% <100.00%> (ø)
graphql_api/types/bundle_analysis/report.py 100.00% <100.00%> (ø)
services/bundle_analysis.py 100.00% <100.00%> (ø)

Impacted file tree graph

codecov-public-qa[bot] avatar Jun 26 '24 20:06 codecov-public-qa[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.95%. Comparing base (7a2b8df) to head (ef09a60). Report is 289 commits behind head on main.

:white_check_mark: All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #642   +/-   ##
=======================================
  Coverage   95.94%   95.95%           
=======================================
  Files         799      799           
  Lines       17872    17886   +14     
=======================================
+ Hits        17148    17162   +14     
  Misses        724      724           
Flag Coverage Δ
unit 91.55% <100.00%> (+<0.01%) :arrow_up:
unit-latest-uploader 91.55% <100.00%> (+<0.01%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jun 26 '24 20:06 codecov[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

:white_check_mark: All tests successful. No failed tests found.

:loudspeaker: Thoughts on this report? Let us know!