codecov-api icon indicating copy to clipboard operation
codecov-api copied to clipboard

Update shared library to include report models and migrations

Open michelletran-codecov opened this issue 1 year ago • 5 comments
trafficstars

Purpose/Motivation

This update to the shared library will include the changes to update report coverage precision.

Links to relevant tickets

ref: https://github.com/codecov/engineering-team/issues/1631

Notes to Reviewer

Full list of changes to shared in here: https://github.com/codecov/shared/compare/codecov:f6c2c3852530192ab0c6b9fd0c0a800c2cbdb16f%5E%5E%5E%5E%5E...codecov:ae6e12f3cf43188a6d6fa0156ccb78252d3405a8

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

michelletran-codecov avatar May 22 '24 13:05 michelletran-codecov

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

:white_check_mark: All tests successful. No failed tests found.

:loudspeaker: Thoughts on this report? Let us know!

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 91.37%. Comparing base (1979f83) to head (2349e77).

:white_check_mark: All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #578   +/-   ##
=======================================
  Coverage   91.37%   91.37%           
=======================================
  Files         601      601           
  Lines       16003    16003           
=======================================
  Hits        14623    14623           
  Misses       1380     1380           
Flag Coverage Δ
unit 91.37% <ø> (ø)
unit-latest-uploader 91.37% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-qa[bot] avatar May 22 '24 14:05 codecov-qa[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 91.37%. Comparing base (1979f83) to head (2349e77).

:white_check_mark: All tests successful. No failed tests found :relaxed:

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #578   +/-   ##
=======================================
  Coverage   91.37%   91.37%           
=======================================
  Files         601      601           
  Lines       16003    16003           
=======================================
  Hits        14623    14623           
  Misses       1380     1380           
Flag Coverage Δ
unit 91.37% <ø> (ø)
unit-latest-uploader 91.37% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted file tree graph

codecov-public-qa[bot] avatar May 22 '24 14:05 codecov-public-qa[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.84%. Comparing base (1979f83) to head (2349e77).

:white_check_mark: All tests successful. No failed tests found.

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #578   +/-   ##
=====================================
  Coverage   95.84   95.84           
=====================================
  Files        779     779           
  Lines      17321   17321           
=====================================
  Hits       16602   16602           
  Misses       719     719           
Flag Coverage Δ
unit 91.37% <ø> (ø)
unit-latest-uploader 91.37% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 22 '24 18:05 codecov[bot]

I tested this locally (both with and without the migration) and found that the code is more or less backwards compatible. Since the migration on the database is going to happen after the code is released (because risky migration), it is important that this code will work with the old column (numeric(7, 2)).

Once I get an approval, I will migrate and test on staging.

michelletran-codecov avatar May 22 '24 18:05 michelletran-codecov