codecov-api icon indicating copy to clipboard operation
codecov-api copied to clipboard

Add update self hosted settings mutation

Open rohitvinnakota-codecov opened this issue 9 months ago • 4 comments

Purpose/Motivation

This PR closes https://github.com/codecov/engineering-team/issues/1473. We want to move our REST endpoints to GQL. This change creates a mutation and adds an additional resolver that will be consumed in gazebo in useSelfHostedSettings and AutoActivateMembers (we are currently making a GET and PATCH REST call).

A follow up PR will be made in gazebo to migrate the endpoints.

After that, we will delete the old REST code, once we confirm that it is no longer in use.

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

rohitvinnakota-codecov avatar May 13 '24 15:05 rohitvinnakota-codecov

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.86%. Comparing base (e1af712) to head (99c3b08).

:white_check_mark: All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##            main    #559     +/-   ##
=======================================
+ Coverage   95.84   95.86   +0.02     
=======================================
  Files        779     782      +3     
  Lines      17320   17370     +50     
=======================================
+ Hits       16601   16651     +50     
  Misses       719     719             
Flag Coverage Δ
unit 91.40% <100.00%> (+0.02%) :arrow_up:
unit-latest-uploader 91.40% <100.00%> (+0.02%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 13 '24 15:05 codecov[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

:white_check_mark: All tests successful. No failed tests found.

:loudspeaker: Thoughts on this report? Let us know!

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 91.40%. Comparing base (e1af712) to head (99c3b08).

:white_check_mark: All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #559      +/-   ##
==========================================
+ Coverage   91.37%   91.40%   +0.02%     
==========================================
  Files         601      604       +3     
  Lines       16002    16052      +50     
==========================================
+ Hits        14622    14672      +50     
  Misses       1380     1380              
Flag Coverage Δ
unit 91.40% <100.00%> (+0.02%) :arrow_up:
unit-latest-uploader 91.40% <100.00%> (+0.02%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-qa[bot] avatar May 13 '24 15:05 codecov-qa[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 91.40%. Comparing base (e1af712) to head (99c3b08).

:white_check_mark: All tests successful. No failed tests found :relaxed:

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #559      +/-   ##
==========================================
+ Coverage   91.37%   91.40%   +0.02%     
==========================================
  Files         601      604       +3     
  Lines       16002    16052      +50     
==========================================
+ Hits        14622    14672      +50     
  Misses       1380     1380              
Flag Coverage Δ
unit 91.40% <100.00%> (+0.02%) :arrow_up:
unit-latest-uploader 91.40% <100.00%> (+0.02%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...s/owner/interactors/update_self_hosted_settings.py 100.00% <100.00%> (ø)
codecov_auth/commands/owner/owner.py 100.00% <100.00%> (ø)
graphql_api/types/config/config.py 100.00% <100.00%> (ø)
graphql_api/types/mutation/__init__.py 100.00% <100.00%> (ø)
graphql_api/types/mutation/mutation.py 100.00% <100.00%> (ø)
...s/mutation/update_self_hosted_settings/__init__.py 100.00% <100.00%> (ø)
...elf_hosted_settings/update_self_hosted_settings.py 100.00% <100.00%> (ø)

Impacted file tree graph

codecov-public-qa[bot] avatar May 13 '24 15:05 codecov-public-qa[bot]