codecov-action icon indicating copy to clipboard operation
codecov-action copied to clipboard

Plumb failCi into verification function.

Open RobbieMcKinstry opened this issue 3 years ago • 2 comments

This PR resolves https://github.com/codecov/codecov-action/issues/768 by respecting fail_ci_on_error when uploader validation fails.

RobbieMcKinstry avatar Jun 23 '22 17:06 RobbieMcKinstry

Codecov Report

Merging #769 (66298c8) into master (8e09eaf) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #769   +/-   ##
=======================================
  Coverage   95.26%   95.26%           
=======================================
  Files           4        4           
  Lines         169      169           
  Branches       48       48           
=======================================
  Hits          161      161           
  Misses          8        8           
Flag Coverage Δ
demo 80.00% <ø> (ø)
macos-latest 95.26% <ø> (ø)
script 96.75% <ø> (ø)
ubuntu-latest 95.26% <ø> (ø)
version 80.00% <ø> (ø)
windows-latest 95.26% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/buildExec.ts 98.33% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8e09eaf...66298c8. Read the comment docs.

codecov[bot] avatar Jun 23 '22 18:06 codecov[bot]

Hey, just wanted to follow up on this, let me know if you need any changes, friends! 👍🏻

RobbieMcKinstry avatar Jul 06 '22 21:07 RobbieMcKinstry

@RobbieMcKinstry I'll cut a new release sometime next week, thanks for the PR!

thomasrockhu-codecov avatar Sep 08 '22 17:09 thomasrockhu-codecov