codecov-action icon indicating copy to clipboard operation
codecov-action copied to clipboard

Use Node.js 20 for v3

Open vkottler opened this issue 1 year ago • 5 comments

The v3 action branch triggers the following deprecation warning when used in actions:

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: codecov/codecov-action@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

(example PR)

Is it viable to update v3 to use Node.js 20? The v4 version of this action deletes features compared to v3.

vkottler avatar Feb 12 '24 21:02 vkottler

Hi @vkottler - what features in v3 are you missing in v4?

rohan-at-sentry avatar Feb 12 '24 21:02 rohan-at-sentry

Per "Breaking Changes" in README.md: Tokenless uploading is unsupported.. This broke my projects' actions and I had to migrate from main to v3.

There doesn't seem to be any compelling reason to set up an API token + store it in a per-repository secret + update action YAMLs so that codecov-action will continue performing the exact same task it previously performed without additional requirements.

vkottler avatar Feb 12 '24 22:02 vkottler

Currently v4 is not usable for me in several repos due to #1287.

felixfontein avatar Feb 15 '24 06:02 felixfontein

@felixfontein - we'll take a look at what's going on in #1287

rohan-at-sentry avatar Feb 15 '24 16:02 rohan-at-sentry

@vkottler Thanks for clarifying. For context, we're not actively supporting v3 beyond critical security fixes.

The primary rationale around upgrading to v4 and having tokens is around reducing service downtime as a result of Codecov's Github app token being rate-limited. The token needs to be generated on the Codecov UI and set as a repo secret.

If you have any questions on setting up the token, let us know, we're happy to help

rohan-at-sentry avatar Feb 15 '24 16:02 rohan-at-sentry

@vkottler v3.1.5 supports node20. Closing this out for now as we will not be migrating up to node20 for v3 as it is a breaking change for many users.

thomasrockhu-codecov avatar Feb 20 '24 15:02 thomasrockhu-codecov

@thomasrockhu-codecov dope!!! It works great thanks for the suggestion and implementation.

vkottler avatar Feb 21 '24 03:02 vkottler