browser-extension icon indicating copy to clipboard operation
browser-extension copied to clipboard

Uncaught ReferenceError: $ is not defined

Open lbergelson opened this issue 7 years ago • 6 comments

I noticed that the code coverage is only showing up sporadicly on pull requests. I'm not sure why I see it sometimes and why sometimes I don't. I looked in the console and it seems like there's an error in one of the codecov listening scripts though. Googling around makes it sound like it might be problem with jquery not being available.

screen shot 2018-03-20 at 12 37 11 pm screen shot 2018-03-20 at 12 37 19 pm

lbergelson avatar Mar 20 '18 16:03 lbergelson

I'm seeing this as well.

dannyroa avatar Mar 28 '18 16:03 dannyroa

I'm seeing this too. Likely needs to add an additional check for typeof $ === "undefined"

ianepperson avatar Mar 28 '18 22:03 ianepperson

Yeah me too :(

aidanlister avatar Apr 14 '18 12:04 aidanlister

Me too

jallen1788 avatar May 14 '18 13:05 jallen1788

...or simply remove usage of jQuery entirely, as addEventListener and postMessage are widely supported now.

@stevepeak Would you accept a PR on this? I proposed the change in #58

amercier avatar Jun 16 '18 07:06 amercier

I hope this will be fixed. We're paying for your service and we don't even get a response from you.

dannyroa avatar Jun 24 '18 05:06 dannyroa