browser-extension icon indicating copy to clipboard operation
browser-extension copied to clipboard

Coverage did not change is reported even though it changed

Open wilzbach opened this issue 8 years ago • 3 comments

image

from this PR https://github.com/dlang/phobos/pull/4647

It seems to be an UI error, maybe the overall coverage is only reported from the first file of the diff or there is some rounding involved?

wilzbach avatar Jul 30 '16 21:07 wilzbach

I also get other weird UI errors - like this one (the coverage did change)

image

https://github.com/dlang/phobos/pull/4680/files

wilzbach avatar Aug 15 '16 13:08 wilzbach

coverage did change

This may be the case when overall coverage is equal and the diff does not affect the overall coverage. Ex.

# overall coverage before 50%

- this line was hit
+ this line was hit
- miss
- miss
- miss
+ miss
+ miss
+ miss

# diff coverage is 25%
# coverage after 50%. Diff 50%

stevepeak avatar Aug 15 '16 13:08 stevepeak

#+

jammyto10 avatar Oct 15 '17 11:10 jammyto10