codeclimate icon indicating copy to clipboard operation
codeclimate copied to clipboard

Show progress during Makefile install process

Open noahd1 opened this issue 9 years ago • 5 comments

I installed the CLI via brew and it took 3.5 minutes. I looked at the process list and likely most of that time was taken up by updating local docker images. This seems fine, but more progress output would have been helpful, as it looked like the install had hung.

[2.2.2][21:16][~]$ brew install codeclimate
==> Installing codeclimate from codeclimate/homebrew-formulae
==> Downloading https://github.com/codeclimate/codeclimate/archive/v0.8.1.tar.gz
Already downloaded: /Library/Caches/Homebrew/codeclimate-0.8.1.tar.gz
==> env PATH=/usr/local/bin:/usr/local/Library/ENV/4.3:/usr/bin:/bin:/usr/sbin:/sbin PREFIX=/usr/local/Cellar/codeclimate/0.8.1 ma
🍺  /usr/local/Cellar/codeclimate/0.8.1: 4 files, 16K, built in 3.6 minutes

noahd1 avatar Oct 19 '15 01:10 noahd1

Alternatively, don't run the docker pull during install, but print post-install instructions to do so.

noahd1 avatar Oct 19 '15 02:10 noahd1

I'm in favor of being more explicit and telling the user a command to run to update engines images. However, others may want to err on the side of convenience, which I'm fine with, and agree we should be showing some output (if possible) so it doesn't appear frozen.

pbrisbin avatar Oct 19 '15 13:10 pbrisbin

This issue seems stale, but I want to add my support for it. My make install took over 7 minutes. I ended up executing watch 'sh -c "docker image ls | grep code"' just so I had some proof that it wasn't frozen.

$ brew reinstall codeclimate
==> Reinstalling codeclimate/formulae/codeclimate
==> Downloading https://github.com/codeclimate/codeclimate/archive/v0.72.0.tar.gz
==> make install
🍺  /usr/local/Cellar/codeclimate/0.72.0: 5 files, 43.6KB, built in 7 minutes 14 seconds

taiidani avatar Apr 30 '18 18:04 taiidani

I think that's great feedback. The make install process currently does print output, but I suppose the brew install step may suppress it. I'm curious if brew install --verbose codeclimate would avoid suppressing the output, and if so, if we should recommend folks use it. What do you think?

maxjacobson avatar Apr 30 '18 19:04 maxjacobson

That definitely shows the output! Now if only that were the default :)

At the least that gives me an easy response for developers wanting to know what's going on under the hood during their installs.

taiidani avatar May 14 '18 00:05 taiidani