Peter Gafert

Results 216 comments of Peter Gafert

Yes, feel free :smiley: I don't think generic "contextual" information (like which field was read before this method was called) is necessary for the DSL right now, also this would...

@JohT I tried to play around with it, but so far I couldn't manage to find a way to not also lose critical information in cases of overridden methods with...

@JohT thanks a lot for your example!! :+1: That makes it a lot easier for me. I think that is a different issue though (and not trivial, I have to...

Also, maybe you could make the commit message a little more elaborate :slightly_smiling_face: Because "some issues" is quite fuzzy. What about "explicitly distinguish between direct and subpackage dependencies" or sth....

Hey, sorry, I was knocked out a little the recent weeks :grimacing: I answered at your comment. Given what you said, do you think it would make more sense to...

Since you seem a little overloaded to push this forward at the moment I created some fixups with some review suggestions (including the renaming from `ThisPackageAndAllSubpackages` to `ThisPackageTree`, since you...

No worries, as I said, I know how it is with this extra time for OSS :wink:

Thanks a lot for your thorough review!! :smiley: And for finding all the places in test code where I overlooked replacing "package and subpackages" by "package tree" :see_no_evil:

Yes, the actual throws statement is not supported yet, only throws declarations and catch clauses. I don't know how tricky it would be to add it :thinking: AFAIS it would...

Hi @mslowiak, that's great! But just a warning, this might be a challenging issue :wink: (in other words, there are probably lower hanging fruits within the other open issues) But...