CodeceptJS icon indicating copy to clipboard operation
CodeceptJS copied to clipboard

Adding methods to locator.js - withAttrEndsWith, withAttrStartsWith, withAttrContains

Open Maksym-Artemenko opened this issue 1 year ago • 1 comments

Motivation/Description of the PR

Adding methods to locator.js - withAttrEndsWith, withAttrStartsWith, withAttrContains I believe those methods are needed for many CodeceptJS users

All methods are compartible with XPath 1.0, All methods tested - working as expected.

Applicable helpers:

  • [ ] Playwright
  • [ ] Puppeteer
  • [ ] WebDriver
  • [ ] REST
  • [ ] FileHelper
  • [ ] Appium
  • [ ] TestCafe

Applicable plugins:

  • [ ] allure
  • [ ] autoDelay
  • [ ] autoLogin
  • [ ] customLocator
  • [ ] pauseOnFail
  • [ ] coverage
  • [ ] retryFailedStep
  • [ ] screenshotOnFail
  • [ ] selenoid
  • [ ] stepByStepReport
  • [ ] stepTimeout
  • [ ] wdio
  • [ ] subtitles

Type of change

  • [ ] :fire: Breaking changes
  • [ ] :rocket: New functionality
  • [ ] :bug: Bug fix
  • [ ] 🧹 Chore
  • [ ] :clipboard: Documentation changes/updates
  • [ ] :hotsprings: Hot fix
  • [ ] :hammer: Markdown files fix - not related to source code
  • [ ] :nail_care: Polish code

Checklist:

  • [ ] Tests have been added
  • [ ] Documentation has been added (Run npm run docs)
  • [ ] Lint checking (Run npm run lint)
  • [ ] Local tests are passed (Run npm test)

Maksym-Artemenko avatar May 03 '24 05:05 Maksym-Artemenko

I agree with @kobenguyent Please add tests

DavertMik avatar May 03 '24 18:05 DavertMik

  • Merged with main branch.
  • Added UTs.

kobenguyent avatar Aug 13 '24 14:08 kobenguyent