CodeceptJS icon indicating copy to clipboard operation
CodeceptJS copied to clipboard

check if browser is W3C instead of Android

Open mikk150 opened this issue 3 years ago • 2 comments

Motivation/Description of the PR

My first implementation to this was stupid, this is way better one

  • Resolves #3317

Applicable helpers:

  • [x] WebDriver
  • [ ] Puppeteer
  • [ ] Nightmare
  • [ ] REST
  • [ ] FileHelper
  • [ ] Appium
  • [ ] Protractor
  • [ ] TestCafe
  • [ ] Playwright

Applicable plugins:

  • [ ] allure
  • [ ] autoDelay
  • [ ] autoLogin
  • [ ] customLocator
  • [ ] pauseOnFail
  • [ ] coverage
  • [ ] retryFailedStep
  • [ ] screenshotOnFail
  • [ ] selenoid
  • [ ] stepByStepReport
  • [ ] stepTimeout
  • [ ] wdio
  • [ ] subtitles

Type of change

  • [ ] :fire: Breaking changes
  • [ ] :rocket: New functionality
  • [ ] :bug: Bug fix
  • [ ] :clipboard: Documentation changes/updates
  • [ ] :hotsprings: Hot fix
  • [ ] :hammer: Markdown files fix - not related to source code
  • [x] :nail_care: Polish code

Checklist:

  • [ ] Tests have been added
  • [ ] Documentation has been added (Run npm run docs)
  • [ ] Lint checking (Run npm run lint)
  • [ ] Local tests are passed (Run npm test)

mikk150 avatar Sep 19 '22 15:09 mikk150

Hi @mikk150 so this check would be sufficient for both android and iOS right? Just out of curiosity.

kobenguyent avatar Sep 19 '22 17:09 kobenguyent

Hi @mikk150 so this check would be sufficient for both android and iOS right? Just out of curiosity.

if webdriverio reports iOS as W3C browser(Which it should, because it is really Appium), then I do not see why not

mikk150 avatar Sep 20 '22 08:09 mikk150

Thanks!

DavertMik avatar Sep 25 '22 20:09 DavertMik