CodeceptJS icon indicating copy to clipboard operation
CodeceptJS copied to clipboard

REST: Changed "endpoint" to optional

Open mirao opened this issue 2 years ago • 2 comments

Motivation/Description of the PR

When I switched to TypeScript config in CodeceptJS 3.3.5, CodeceptJS forced me to specify endpoint: "" though I don't use this property at all. Every REST API call in my tests is performed to absolute URL http(s):// (because test switches between several servers), so I don't need endpoint Moreover I noticed that default value of endpoint in REST helper is already an empty string, so I think that it's not needed to specify it from test's config: https://github.com/codeceptjs/CodeceptJS/blob/3.x/lib/helper/REST.js#L62

Applicable helpers:

  • [ ] WebDriver
  • [ ] Puppeteer
  • [ ] Nightmare
  • [x] REST
  • [ ] FileHelper
  • [ ] Appium
  • [ ] Protractor
  • [ ] TestCafe
  • [ ] Playwright

Applicable plugins:

  • [ ] allure
  • [ ] autoDelay
  • [ ] autoLogin
  • [ ] customLocator
  • [ ] pauseOnFail
  • [ ] coverage
  • [ ] retryFailedStep
  • [ ] screenshotOnFail
  • [ ] selenoid
  • [ ] stepByStepReport
  • [ ] stepTimeout
  • [ ] wdio
  • [ ] subtitles

Type of change

  • [ ] :fire: Breaking changes
  • [ ] :rocket: New functionality
  • [x] :bug: Bug fix
  • [ ] :clipboard: Documentation changes/updates
  • [ ] :hotsprings: Hot fix
  • [ ] :hammer: Markdown files fix - not related to source code
  • [ ] :nail_care: Polish code

Checklist:

  • [ ] Tests have been added
  • [ ] Documentation has been added (Run npm run docs)
  • [x] Lint checking (Run npm run lint)
  • [x] Local tests are passed (Run npm test)

mirao avatar Aug 31 '22 16:08 mirao

It looks like the failed test sometimes passes and sometimes fails (tested even in my local environment). BTW is it possible to re-run the job in GitHub Actions? I didn't find a way how to do it.

mirao avatar Aug 31 '22 17:08 mirao

Thanks, i didn't think of that I will look and merge PR before release

DavertMik avatar Sep 13 '22 14:09 DavertMik