helm-charts icon indicating copy to clipboard operation
helm-charts copied to clipboard

feat(keycloakx): Support optimized start

Open mruzicka opened this issue 1 year ago • 1 comments

This PR makes the chart aware of the so called optimized start of Keycloak. This optimized start is achieved by passing the --optimized argument to the Keycloak's start command:

kc.[sh|bat] start --optimized ...

When Keycloak is started this way it assumes it had already been optimized (see Creating an optimized Keycloak build) and ignores options which only take effect during the optimization process but does log a warning when it encounters them. The warning may look something like this:

WARN  [org.keycloak.quarkus.runtime.cli.Picocli] (main) The following build time non-cli options were found, but will be ignored during run time: kc.cache, kc.cache-stack, kc.http-relative-path, kc.health-enabled, kc.metrics-enable

The intent of this PR is to get rid of this warning by not passing the build/optimization-time only options when an optimized start is used. For that purpose a boolean value optimized is introduced which is used to guard the rendering of the build-time only options.

Note that the kc.cache* options are in fact run-time options (even though mentioned in the example warning above). This is a bug in the definition of these options in Keycloak. It's already been fixed in https://github.com/keycloak/keycloak/commit/a3669a6562dd190b2ec48e10de8250a3fb7fcfca, so once this is released, Keycloak will stop complaining about those.

mruzicka avatar Apr 23 '24 10:04 mruzicka

This pull request has been marked as stale because it has been open for 30 days with no activity. It will be automatically closed in 10 days if no further activity occurs.

github-actions[bot] avatar Jun 26 '24 12:06 github-actions[bot]

I've updated the PR's source branch, could someone please reopen the PR?

mruzicka avatar Jul 18 '24 17:07 mruzicka