gopass-ui icon indicating copy to clipboard operation
gopass-ui copied to clipboard

Put password health results into some kind of global state to cache it per "application session"

Open jonas-pietzsch opened this issue 6 years ago • 3 comments

The password health should only be reviewed once per application usage.

jonas-pietzsch avatar Apr 10 '19 21:04 jonas-pietzsch

Refactored the global password-health feature in a way that rating was removed from the rendering process. It is now deterministic when the state is ready and when it has stored a finished password-rating result. This result can be taken to be persisted for a temporary time now. It could be invalidated by:

  • Simply time: it gets a max age, when it's over the check will run again
  • All secrets' checksum (can we get a checksum over all stores from Gopass?!): if something changed, calculate again
  • Edited/removed/added secrets through Gopass UI. Disadvantage of not tracking modifications via CLI...

jonas-pietzsch avatar Apr 15 '19 21:04 jonas-pietzsch

TODO: put the finished results into the system settings. First iteration will use the "simply time" implementation to keep it simple ATM.

jonas-pietzsch avatar Apr 15 '19 21:04 jonas-pietzsch

In addition, it would be great if one could go back to the list directly after having selected and inspected one of the suggested improvements.

Besides, except the colour, it is not clear that these passwords can be clicked on in the first place. At least the cursor icon could change or similar

svenXY avatar Apr 29 '20 08:04 svenXY