laravel-jwt icon indicating copy to clipboard operation
laravel-jwt copied to clipboard

Published 20 hours ago • verified publisher icon codecasts

Is this production ready?

Open jonagoldman opened this issue 8 years ago • 9 comments
trafficstars

Was looking for a Tymon JWT alternative and found this repo. Looks nice but noticed, for example, that logout functionality is not implemented. So I was wondering if this repo is ready for production or are there any other unknown unfinished parts? Thanks.

jonagoldman avatar Aug 12 '17 15:08 jonagoldman

Hi, that's the only thing left, gonna push the logout functionality soon, but when dealing with JWT, logout means blacklisting a token

hernandev avatar Aug 16 '17 03:08 hernandev

Oh great! Was looking for a simpler JWT package. Thanks!

jonagoldman avatar Aug 16 '17 07:08 jonagoldman

I just found this repo as well and would love to give it a fair shot. Is there an ETA of getting the logout functionality working?

michaelcurry avatar Aug 29 '17 20:08 michaelcurry

Hey guys, I'm using it on production, apart from blacklisting tokens, the rest of the functionalities are just helpers for you to plug on the controllers. I'm releasing it either way on the weekend.

Thank you guys for the support.

hernandev avatar Aug 29 '17 22:08 hernandev

Sounds good. As I look into using this package, If i require "blacklisting" you may have a pull request to look at :+1:

michaelcurry avatar Aug 29 '17 23:08 michaelcurry

Starting to work on the blacklisting now.

It will be done by a caching, instead of storage.

Any ideas, feel free to contribute.

Thank you all!

hernandev avatar Apr 09 '18 15:04 hernandev

Next time don't believe me, not even I remembered I was pending on this.

hernandev avatar Aug 26 '18 04:08 hernandev

BTW, just noticing the title here, please take my advice when looking at software:

OSS is just OSS, production ready is just a marketing term people put on landing pages to win flame wars.

OSS is never production ready because there are no warranties, of any kind. Understand open source software you plug on your projects because when it comes to it, you're the only one accountable.

hernandev avatar Aug 26 '18 04:08 hernandev

"Software is never Production Ready" is the sign of a coding amateur.

All of my packages, when they reach v1.0 and have 100% automated test code coverage, are ready for production. And I'll stake my professional reputation on them behaving correctly.

I've run into this exact same problem with tymon/jwt-auth never feeling like he's ready for v1.0.0.

hopeseekr avatar Jul 01 '19 04:07 hopeseekr