QRCoder icon indicating copy to clipboard operation
QRCoder copied to clipboard

Add Micro QR code support

Open Shane32 opened this issue 7 months ago • 10 comments

Prerequisites (to reduce diff):

  • #590

Status:

  • All generated micro QR codes are scannable
  • Most QR codes match the output of the segno python library
  • Need to add tests and validate combinations of lengths, character types, etc

Side notes:

  • ASCII small generator has x/y swapped and prints inverted compared to regular ASCII generator
  • The segno python library does not apply padding properly so micro QR codes consisting mostly of padding don't match

Shane32 avatar Apr 13 '25 05:04 Shane32

M2 codes will generate correctly now

Shane32 avatar Apr 14 '25 03:04 Shane32

Still a little more work to do, but it appears to be generating readable codes for all micro QR code sizes now.

Shane32 avatar Apr 16 '25 02:04 Shane32

This implementation is complete. I might add some more tests but everything is working.

Shane32 avatar Apr 19 '25 15:04 Shane32

I'm looking forward to review the PR, but after https://github.com/codebude/QRCoder/pull/590 got merged so I can focus on the new stuff.

@Shane32 👍🏻 for your work

gfoidl avatar Apr 23 '25 09:04 gfoidl

@gfoidl #590 is merged now.

codebude avatar Jun 02 '25 07:06 codebude

@Shane32 please merge the master-branch in your micro-branch, so that the latest changes are in and the diff becomes smaller for review 😉. IIRC GitHub doesn't do that automatically.

gfoidl avatar Jun 02 '25 13:06 gfoidl

I've merged it, but it looks like the CI scripts are failing again...

Shane32 avatar Jun 02 '25 13:06 Shane32

Thanks @gfoidl !

Shane32 avatar Jun 02 '25 21:06 Shane32

CI scripts have been fixed - @codebude can you review?

Shane32 avatar Jun 13 '25 02:06 Shane32

Hey @codebude do you have a little time to review this PR?

Shane32 avatar Jun 16 '25 22:06 Shane32

@codebude Any update here?

Shane32 avatar Aug 17 '25 14:08 Shane32

@codebude Think we could merge this in?

Shane32 avatar Sep 01 '25 20:09 Shane32

Hi @Shane32 ,

since QRCoder will reach its end of life and the repository will be archived on November 1st, 2025, I’d like to clarify how to proceed with this PR.

Would you prefer me to merge it before the archival, or should I close it instead?
Please let me know what you think – I want to handle your contribution in the way that feels most appropriate to you.

Thanks again for your effort and contribution!

codebude avatar Sep 27 '25 21:09 codebude

@codebude As you know, I've put in a considerable amount of effort recently with refactoring, xml documentation, speed improvements, and most recently adding support of Micro QR codes. As an alternative to archiving the repository, I was wondering if you'd consider transferring the project to me to continue further maintenance and development.

Please review my profile; you will find I'm currently the primary maintainer of GraphQL.NET which presently has a total of 57M downloads, as well as a collaborator of linq2db. I also have personally created and/or maintain a number of other open source projects as seen here:

  • https://www.nuget.org/profiles/Shane32
  • https://www.npmjs.com/~shane32
  • https://github.com/Shane32

I have a strong commitment to high-quality, open-source (MIT licensed) code, wide technology support, community approval of changes, and quick response time to support requests.

While I could fork the repository and publish it under a new name, I feel that it would be in the best interest of users if I could continue supporting the project directly. If you’re interested, please let me know.

Thank you again for all the time and effort you’ve put into creating and maintaining this package — it has been a valuable resource for the community.

Shane32 avatar Sep 28 '25 10:09 Shane32

This PR includes changes within #596 --- recommend to merge #596 first

Shane32 avatar Sep 30 '25 12:09 Shane32