geany-zencoding icon indicating copy to clipboard operation
geany-zencoding copied to clipboard

Couple of points I noticed.

Open elextr opened this issue 13 years ago • 1 comments

Couple of points I noticed, wasn't by any means a real review.

  1. some of the keybindings clash with standard ones, ++e and t at least, didn't check all the rest.
  2. in zen_controller_init_python() the variable resident_pylib is static so its only ever initialised to NULL once, not sure if thats part of your commented intermittent crash on subsequent calls
  3. even if the python lib isn't found you fall through to try to initialise anyway, that would probably be a crash.

elextr avatar Oct 16 '12 12:10 elextr

That's all you found? :)

I haven't even really touched this since last year, so not too bad :)

codebrainz avatar Oct 16 '12 14:10 codebrainz