py icon indicating copy to clipboard operation
py copied to clipboard

Applied undersampling,oversampling & smote for your Assignment 2

Open Abdur-Rahim-sheikh opened this issue 4 years ago • 2 comments

I implemented the whole code from scratch, And as you asked to give a pull request. So I did. Thank you for your great service.

F1 score for, Undersampling = 74% Oversampling = 78% smote = 81%

Abdur-Rahim-sheikh avatar Sep 14 '21 04:09 Abdur-Rahim-sheikh

Hey, thanks for the pull request. Please make following changes,

  1. Rename the file to follow the snake case convention.
  2. Perform undersampling, oversampling, etc. on the training set, not the entire dataset. I know that's what I did in the original tutorial but that was an oversight. Ideally, we need to perform these operations on a training set only to avoid data leakage.

dhavalsays avatar Jul 16 '24 20:07 dhavalsays

Sir, i renamed the file in snake case format. And only sampled data on train set. My latest push has the update.

I'm glad that, i'm following since 2021. And the pull request was 3 years ago and you are still reviewing it.

Abdur-Rahim-sheikh avatar Jul 18 '24 05:07 Abdur-Rahim-sheikh