planner icon indicating copy to clipboard operation
planner copied to clipboard

New announcement endpoint allows for announcing to entire membership

Open jonodrew opened this issue 6 months ago • 6 comments

The endpoint /admin/announcements/new has no limits on which chapters you can contact. We should reduce that to only those that an admin has responsibility for, ie their chapter

jonodrew avatar Aug 20 '25 15:08 jonodrew

If an admin has to make an announcement to all chapters they have to undo this change?

davidmillen50 avatar Aug 20 '25 16:08 davidmillen50

I'm pretty confident the answer is no, because I've used the filter on Chapters. I think a global admin has access to all chapters - and if not, I think it's simple enough to make oneself an admin of all Chapters. https://github.com/codebar/planner/pull/2297/commits/f3e1ad865390f22ade1e78af05937ad2a6167884

jonodrew avatar Aug 20 '25 16:08 jonodrew

Looking at the list of announcements made under /admin/announcements, it looks like they are infrequent and have only been done by senior codebar people (Kim, Despo, Kriszta). Given that the page allows communicating with all chapters, the combination of these two things makes me think that this page is only intended for admin users rather than for organisers to communicate with their chapter. So I suspect that the page as a whole should be restricted to those with "admin" permission rather than keeping the current permission level and filtering for chapters an organiser is in.

@KimberleyCook The newest announcement is by you in December 2024 (CFP for Codebar Festival). Are you able to give us guidance on the intended users of the announcements page?

biggianteye avatar Aug 20 '25 20:08 biggianteye

@jonodrew @biggianteye is correct, this functionality is only intended to be used by admins. It was added so we can communicate codebar wide announcements to the whole community (aka everyone across all geographical regions) or a subset of chapters (e.g. all UK chapters) or even just a couple of chapters. Please do leave it as it is for now, so only admins can access and set announcements. If this is something organisers would find useful I'm happy to explore how we could open this functionality up to them, allowing them to post messages to their own chapter. It is however not a priority for us at the moment.

matyikriszta avatar Aug 21 '25 00:08 matyikriszta

I think we need to review permissions then - I shared the endpoint in the organisers channel on Slack and at least one of them can access it

On 21 August 2025 01:45:09 BST, Kriszta Matyi @.***> wrote:

matyikriszta left a comment (codebar/planner#2296)

@jonodrew @biggianteye is correct, this functionality is only intended to be used by admins. It was added so we can communicate codebar wide announcements to the whole community (aka everyone across all geographical regions) or a subset of chapters (e.g. all UK chapters) or even just a couple of chapters. Please do leave it as it is for now (aka only admins can access and set announcements). If this is something organisers would find useful I'm happy to explore how we could open this functionality up to them, allowing them to post messages to their own chapter. It is however not a priority for us at the moment.

-- Reply to this email directly or view it on GitHub: https://github.com/codebar/planner/issues/2296#issuecomment-3208561547 You are receiving this because you were mentioned.

Message ID: @.***>

jonodrew avatar Aug 21 '25 06:08 jonodrew

e.g

Image

jonodrew avatar Aug 21 '25 07:08 jonodrew