planner icon indicating copy to clipboard operation
planner copied to clipboard

Replace deprecated script and install Node directly from nodesource

Open CodeHex opened this issue 2 years ago • 3 comments

Installing Node from nodesource scripts has been very recently deprecated (and sleeps the build for 60s). This replaces the script with installing the signed debian repo directly using the instructions provided here.

Fixes https://github.com/codebar/planner/issues/1926

CodeHex avatar Sep 14 '23 14:09 CodeHex

When I tested this, I had to use the changes in PR https://github.com/codebar/planner/pull/1900, as I'm working on an M1 Mac. It got through the install steps fine, but someone might want to double check it on a different machine

CodeHex avatar Sep 14 '23 14:09 CodeHex

When I tested this, I had to use the changes in PR #1900, as I'm working on an M1 Mac.

I'm glad you used them. Good to get some independent confirmation that they work.

biggianteye avatar Sep 15 '23 08:09 biggianteye

When I tested this, I had to use the changes in PR #1900, as I'm working on an M1 Mac.

I'm glad you used them. Good to get some independent confirmation that they work.

👍 Yeah thanks, I did get a couple of test failures but running the website seems fine

CodeHex avatar Sep 15 '23 08:09 CodeHex

Looks like the install scripts have been undeprecated? https://github.com/nodesource/distributions now suggest we use the script we have in the current Dockerfile.

The docs at https://github.com/nodesource/distributions/blob/master/README.md#faq and https://github.com/nodesource/distributions/wiki/Repository-Manual-Installation#-simplified-installation-using-scripts suggest that the script at https://deb.nodesource.com/setup_20.x is supported and recommended.

Reading the source of https://deb.nodesource.com/setup_20.x it no longer contains any sleep behaviour.

matyikriszta avatar Jul 27 '24 03:07 matyikriszta