david dansby

Results 83 comments of david dansby

Hey @mikhailswift just bumping this just in case you missed my previous comment. Thanks

Oh no problem at all. Got it, makes more sense. I'll make those changes. Thank you

👋 FYI working on this. Will keep you updated. cheers

👋 small update: finally got around to reviewing the code more and looking over https://github.com/weaviate/weaviate/pull/1706 for inspiration. Will start actually writing code later this week/weekend. Will keep you posted with...

@etiennedi the design proposal you first proposed may need to be restricted to just a `limit` param. Given the [comments @dirkkul made in my PR](https://github.com/weaviate/weaviate/pull/4673) having an `after` param may...

@hadfield good call out. However, it seems ordering is expected here after the `after` tenant based on previous discussions (and general pagination behavior) but tenant names are not inherently ordinal....

Yea makes sense given typical behavior of pagination requires both params. Adding the priority queue should be relatively trivial to add, I believe. Curious what weaviate team says about the...

Sorry, this is the first time I'm contributing to weaviate and have no experience with the weaviate code prior so I most likely did misunderstand Etienne and missed the keys...

👋 I went through the `objects` `after` implementation, which makes sense. I think I'm still hung up on location of the key/id of tenant on disk, as the `objects` `after`...

👍 ok that makes more sense. I'll keep y'a updated after I take another look. Thank you for the guidance, Dirk. I appreciate it.