monitorizare-vot-ong icon indicating copy to clipboard operation
monitorizare-vot-ong copied to clipboard

[Counties] Add reordering options in counties list

Open aniri opened this issue 5 years ago • 12 comments

Depends on https://github.com/code4romania/monitorizare-vot-ong/issues/215

Add the option for setting a county as first in the list.

Add the possibility of reordering the counties by drag and dropping the items from the counties table.

Please suggest backend endpoints if needed.

UI available here: https://www.figma.com/file/61NHR7fwmV1Dsv4Pb6F8T7/code4ro_mv_user-management_2018.04.21-(Copy)?node-id=754%3A0

aniri avatar Feb 22 '20 18:02 aniri

Assign to me and I can take a look

Botosio avatar Oct 23 '21 16:10 Botosio

Can you add hacktoberfest to the label also?

Botosio avatar Oct 25 '21 19:10 Botosio

@aniri do you want every time someone drags and drops to send an update to the backend? Do we need a save button?

I'm guessing every time they drag and drop we will save it.

Botosio avatar Oct 25 '21 20:10 Botosio

@aniri what happens if you filter the list and they change the order?

Right now I disabled the drag and drop if the filter is on.

If you filter, the index doesn't match the original order. However, the move to first when the filter is on should be able to work.

Botosio avatar Oct 25 '21 20:10 Botosio

@aniri do you have this icon? image

Botosio avatar Oct 25 '21 20:10 Botosio

hey @Botosio

I'm guessing every time they drag and drop we will save it. Yep, sounds good!

Also good idea with disabling the drag and drop when the filter is on!

Here's the icon :D double up

Thank you!

aniri avatar Oct 26 '21 07:10 aniri

Should there be a post without the ID for new Counties?

image

Botosio avatar Nov 03 '21 11:11 Botosio

yes, it should be a post without id for adding a county and a put with id for editing one.

I'll add a backend issue to adjust these ;) thanks!

aniri avatar Nov 03 '21 13:11 aniri

@aniri sounds good. I made the global change in this next pr to change the word "Country" to "County".... I might have been the culprit in that.

Botosio avatar Nov 05 '21 12:11 Botosio

@aniri we need a delete also, for county

Botosio avatar Nov 05 '21 12:11 Botosio

@Botosio thanks for the suggestion! I added a backend issue for all the mentioned changes :D

aniri avatar Nov 06 '21 14:11 aniri

depends on https://github.com/code4romania/monitorizare-vot/issues/388

aniri avatar Oct 03 '22 18:10 aniri