daily-code
daily-code copied to clipboard
fix(#609)/added pagination on home page
PR Fixes:
- Added pagination
- Implemented Click on Prev and Next
Resolves #609
https://github.com/user-attachments/assets/6b459276-eab8-4476-ba1c-28e7569c8a41
Checklist before requesting a review
- [x] I have performed a self-review of my code
- [x] I assure there is no similar/duplicate pull request regarding same issue
The good question to ask is do we need pagination?
I always prefer to use
cmd + fwhen going through daily-code
Also, doing it client side doesn't make much sense to me.
@hkirat can we merge this?
@toufiqfarhan0 can u give more ctx on why we might need it?
The good question to ask is do we need pagination?
I always prefer to use
cmd + fwhen going through daily-codeAlso, doing it client side doesn't make much sense to me.
@hkirat can we merge this?
@toufiqfarhan0 can u give more ctx on why we might need it?
@devsargam @hkirat
Context: The reason for adding pagination is that users currently have to scroll all the way to the bottom of the landing page to see all the available slides. Pagination would make it easier for users to navigate through the slides without excessive scrolling.
Yes, you're right cmd + f , but it makes homepage look good.(my thought)
And also there is already pagination present I mean buttons, I just made the buttons(previous, next buttons, pagination) works fine when onclicking. You can check this (Pagination already present).
https://github.com/user-attachments/assets/56356d6f-a08c-48c2-bf5b-b445afa3041e
Sorry about the issue name it's bit confusing 🥲