daily-code icon indicating copy to clipboard operation
daily-code copied to clipboard

Performance improvement - [Grey out Prev Button in First page lesson and Next Button in Last page of a lesson]

Open MadhaneeswaranP opened this issue 1 year ago • 4 comments

To enhance performance and prevent unnecessary API calls to the backend, we can implement the following improvements on the lesson page:

  1. Disable Prev Button on First Slide: When the user is on the first slide of the lesson, the Prev Button should be greyed out and disabled. This will visually indicate to the user that they cannot navigate to the previous slide since they are already on the first slide. Additionally, it prevents any accidental clicks that might trigger unnecessary API calls.

  2. Disable Next Button on Last Slide: Similarly, when the user reaches the last slide of the lesson, the Next Button should be greyed out and disabled. This informs the user that they have reached the end of the lesson and cannot proceed further. Disabling the Next Button also prevents any unnecessary API calls that might occur if the user attempts to navigate beyond the last slide.

Daily_Code_Improvements

CC: @hkirat

MadhaneeswaranP avatar Feb 12 '24 03:02 MadhaneeswaranP

If valid request, Can I on this improvement?

MadhaneeswaranP avatar Feb 12 '24 03:02 MadhaneeswaranP

@MadhaneeswaranP hey sorry, I seem to have missed your comment. I'm happy to take back my PR if you wish to work on this.

Thanks, Ritik

RitikBora avatar Feb 14 '24 10:02 RitikBora

@RitikBora No issues. Let it be there 😉

Kindly mention to close this issue once your PR is merged.

MadhaneeswaranP avatar Feb 14 '24 11:02 MadhaneeswaranP

@hkirat could you please have a look?

RitikBora avatar Feb 15 '24 06:02 RitikBora