daily-code icon indicating copy to clipboard operation
daily-code copied to clipboard

fix: touch event in selecting component in catagories, causing bubble problem

Open vishalmishraa opened this issue 2 months ago • 2 comments

Resolves #292

PR FIX :

  • When the user selected an option, the mobile event bubbled up to the nearby link causing unintentional navigation. this problem is with shadcn UI , select component.

Before fix:

https://github.com/code100x/daily-code/assets/64027486/716c86e0-8e5f-40c5-95e3-3362424c27a5

After fix :

https://github.com/code100x/daily-code/assets/64027486/468ec46e-de20-43d3-83b3-b9132030e701

Checklist before requesting a review

  • [ ] I have performed a self-review of my code
  • [ ] I assure there is no similar/duplicate pull request regarding same issue

vishalmishraa avatar Apr 16 '24 18:04 vishalmishraa

Hey @vishalmishraa,

can we not use anything like ? event.stopPropagation();

ssk090 avatar Apr 19 '24 08:04 ssk090

Hey @vishalmishraa,

can we not use anything like ? event.stopPropagation();

I tried it but it didn't work , this one is the last working solution

vishalmishraa avatar Apr 19 '24 10:04 vishalmishraa

/bounty $10

hkirat avatar Apr 21 '24 21:04 hkirat