cms icon indicating copy to clipboard operation
cms copied to clipboard

Feature/linking questions to video

Open Sajal0208 opened this issue 1 year ago • 10 comments

This PR Adds:

  • 1 When creating a question, users now have the option to link it to a specific video.
  • 2 Users can search a video from the search bar present inside the Add Questions Dialog.
  • 3 This feature is optional, as we still want to allow questions without associated videos.
  • 4 Each video has a button that, when clicked, redirects the user to all questions related to the video.
  • 5 Made the necessary database changes
  • 6 Dynamically calculating height of the MEditor to fix the overflow of the Modal Components in Questions Page

Resolves #862

Screenshots Below:

Screenshot 2024-08-09 at 7 21 24 PM Screenshot 2024-08-09 at 10 16 47 PM Screenshot 2024-08-09 at 10 16 53 PM Screenshot 2024-08-09 at 7 51 02 PM Screenshot 2024-08-09 at 7 51 13 PM
  • [✅] I have performed a self-review of my code
  • [✅ ] I assure there is no similar/duplicate pull request regarding same issue

Open to any changes/suggestions/commits to this PR. For contact, DM me on Twitter: https://x.com/DewanganSajal

Sajal0208 avatar Aug 09 '24 14:08 Sajal0208

@Sajal0208 what if we have 500 videos? how the dropdown will look? can we improve it further?

siinghd avatar Aug 09 '24 15:08 siinghd

@siinghd Should I group it like this -

Course Dropdown ->Week Dropdown -> Then Videos Or anyother suggestions?

Sajal0208 avatar Aug 09 '24 15:08 Sajal0208

@siinghd Should I group it like this -

Course Dropdown ->Week Dropdown -> Then Videos Or anyother suggestions?

I have already mentioned this in the issue post, try to look at it buddy

siinghd avatar Aug 09 '24 16:08 siinghd

@siinghd Should I group it like this - Course Dropdown ->Week Dropdown -> Then Videos Or anyother suggestions?

I have already mentioned this in the issue post, try to look at it buddy

Apologies, I might have skipped that point.

The above commit fixes the issue. @siinghd Let me know if anything else needs to be fixed

Sajal0208 avatar Aug 09 '24 16:08 Sajal0208

@Sajal0208 looking promising, will wait little see other PRs too, in while improve with any idea u have

siinghd avatar Aug 10 '24 01:08 siinghd

Hey @siinghd, any updates on the bounty?

Sajal0208 avatar Aug 13 '24 16:08 Sajal0208

@siinghd , can you please merge this PR?

Sajal0208 avatar Aug 17 '24 20:08 Sajal0208

@Sajal0208 i saw zero prs other than this for that issue, will test it today and merge it

siinghd avatar Aug 17 '24 20:08 siinghd

@Sajal0208 i saw zero prs other than this for that issue, will test it today and merge it

@siinghd Alright, makes sense. Let me know if we need to add something else in the PR.

Sajal0208 avatar Aug 17 '24 20:08 Sajal0208

Hey @siinghd, you still haven't merged this PR 😅

Sajal0208 avatar Aug 20 '24 07:08 Sajal0208

@Sajal0208 can you fix the conflicts ?

siinghd avatar Aug 22 '24 00:08 siinghd

@Sajal0208 can you fix the conflicts ?

Hey @siinghd, I have resolved the conflicts

Sajal0208 avatar Aug 23 '24 07:08 Sajal0208

Hey @siinghd, a gentle reminder to merge this PR

Sajal0208 avatar Aug 26 '24 18:08 Sajal0208

Hey @siinghd, I know you are running busy but this PR is on hold since a month. Can you please take a look at the same. I have already resolved the conflicts 3 times and I don't know why the resolve conflict button is not working now. Please have a look at this whenever you have time.

Thanks.

Sajal0208 avatar Sep 05 '24 21:09 Sajal0208