code100x
feat: Add email domain suggestions to signin component
PR Fixes: #843
- Implemented dynamic email domain suggestions based on user input.
- Filtered suggested domains based on partial matches after '@' in email input.
- The code changes are in accordance with the requirements specified in https://github.com/code100x/cms/pull/841#issuecomment-2267227798.
Resolves #843
Checklist before requesting a review
- [X] I have performed a self-review of my code
- [X] I assure there is no similar/duplicate pull request regarding same issue
Hey @hkirat , The code changes are in accordance with the requirements specified in https://github.com/code100x/cms/pull/841#issuecomment-2267227798.
Hey @siinghd , here is a demo showcasing how the feature works.
https://github.com/user-attachments/assets/460c7d38-a90c-4ec6-b0d1-3121d4376290
very nice PR @siinghd @devsargam for review
Thank you! @hkirat , I appreciate the feedback.
Works perfectly locally
Kapture.2024-08-09.at.20.43.07.mp4
@devsargam , do you have the permissions to merge this PR?
very nice PR @siinghd @devsargam for review
Hey @hkirat , can you merge this PR? It has been reviewed by @devsargam .
hey @vijaysingh2219 did u add anything else since I reviewed this pr?
Hey @devsargam , no additional changes since your review. Everything was perfect as is.
ok @vijaysingh2219 this pr will be merged soon. I will check with the guys
ok @vijaysingh2219 this pr will be merged soon. I will check with the guys
Thanks! Sounds good, just let me know if anything else is needed from my side.
@vijaysingh2219 can you fix locks files?
Done! The lock files have been fixed. Let me know if there's anything else you need.
Thank you, @devsargam , for merging the PR! I appreciate the review and your help in moving this forward.