cms icon indicating copy to clipboard operation
cms copied to clipboard

Make a Monorepo

Open hiteshsharma-gh opened this issue 1 year ago • 13 comments

Resolves #755

PR Fixes:

  • [x] One App (next frontend)

  • Packages

  • [x] database (prisma, migrations)

  • [x] ui (shad cn components)

  • [x] eslint

  • [x] tsconfig

  • [x] common (types, zodTypes, zodSchema, lib)

  • Others

  • [x] Docker (Dockerfile and docker-compose.yml)

  • [x] prettier

  • [x] update Readme

  • [x] github templates

  • file structure cms-fs

  • lint and format https://github.com/code100x/cms/assets/141833621/57d1f0a8-5d80-40d1-b771-715e72bc0b48

  • running locally https://github.com/code100x/cms/assets/141833621/5f9ad591-9629-401f-b578-218e19c0ae63

  • running using docker https://github.com/code100x/cms/assets/141833621/8f66ebb9-93e1-4ce4-984f-8dde00bb77ef

Checklist before requesting a review

  • [x] I have performed a self-review of my code

hiteshsharma-gh avatar Jun 15 '24 10:06 hiteshsharma-gh

@hkirat @siinghd resolved all conflicts

hiteshsharma-gh avatar Jun 15 '24 10:06 hiteshsharma-gh

@hkirat this will mess up all the existing PR's i think, don't know how to proceed here.

siinghd avatar Jun 15 '24 15:06 siinghd

@hiteshsharma-gh can you fix these conflicts? ill try to test it in local after that. Ill be stopping merging other PR's for now as they only create conflicts

siinghd avatar Jun 15 '24 15:06 siinghd

@siinghd resolved conflicts aside from that finally learned a bit about rebase after resolving so many conflicts

hiteshsharma-gh avatar Jun 15 '24 15:06 hiteshsharma-gh

husky was not a part of my initial pr it was added when merge other pr will see if daily code settings work

hiteshsharma-gh avatar Jun 16 '24 16:06 hiteshsharma-gh

Husky is not setup properly, can we use daily code setting? https://github.com/code100x/daily-code

Still need to test docker, without docker working fine for what i have tested for now...

will continue looking into this.

My only concern is if we merge this, it will mess up all the existing PR's

if we have to convert to monorepo then i don't think there's any other option @hkirat what is your opinion

hiteshsharma-gh avatar Jun 16 '24 16:06 hiteshsharma-gh

Husky is not setup properly, can we use daily code setting? https://github.com/code100x/daily-code

Still need to test docker, without docker working fine for what i have tested for now...

will continue looking into this.

My only concern is if we merge this, it will mess up all the existing PR's

done sir, used daily code settings with some changes to make it work

hiteshsharma-gh avatar Jun 17 '24 04:06 hiteshsharma-gh

@hiteshsharma-gh thank you sir, will review this and test with docker asap

siinghd avatar Jun 17 '24 04:06 siinghd

whats the status? @siinghd

shantanuSakpal avatar Jul 08 '24 09:07 shantanuSakpal

i think this should be a priority, as people will continue raising pr s using existing structure. or if it still needs some work, but is something that is surely going to be implemented, then i suggest to add hiteshsharma-gh:turborepo in the contributing docs, so that we can follow this structure and do feature implementations, so that it will be less work to update the prs after merge

shantanuSakpal avatar Jul 08 '24 17:07 shantanuSakpal

@shantanuSakpal hsingh is gonna merge it in some time after closing some prs

hiteshsharma-gh avatar Jul 09 '24 07:07 hiteshsharma-gh

Okay, great !

shantanuSakpal avatar Jul 09 '24 08:07 shantanuSakpal

@siinghd still-waiting

hiteshsharma-gh avatar Aug 07 '24 16:08 hiteshsharma-gh