fixed time line for videos with no segments
PR Fixes:
- 1 No timeline for videos without segments
- 2 Reverted to the new video controls and Fixed errors in it. Removed redundant code and added functionality to skip back and forward by double clicking which was missing in new video controls. Resolves https://github.com/code100x/cms/issues/584
Checklist before requesting a review
- [x] I have performed a self-review of my code
- [x] I assure there is no similar/duplicate pull request regarding same issue
Please remove console logs.
Also, This seems like a hacky way of doing it. Try not to show the segments at all if there are no segments, and just show the seekbar.
Please remove console logs.
Also, This seems like a hacky way of doing it. Try not to show the segments at all if there are no segments, and just show the seekbar.
I am not showing segments. Will have to do a lot refractoring as timeline are constructed based on segments only.
I am not showing segments.
I meant you're still making changes in the segment array
I am not showing segments.
I meant you're still making changes in the segment array
I agree this is somewhat hacky. But as I said the code is is in such a way that there is no seekbar timelines are created for each segment with width equal to duration and events are registered for it.
P.S : I am making changes to segments only in a function only. It's kind of local to that that's why segments comp on right and other things related to them don't appear. And thanks for taking timeout to do the review.
reopen, there are many conflicts