cms icon indicating copy to clipboard operation
cms copied to clipboard

Fix: Error while replying to comments + clicking on timestamp + going back from reply

Open mvp5464 opened this issue 1 year ago • 1 comments

PR Fixes:

  • 1 Fixed error while clicking on replying button in comments.
  • 2 Fixed error while clicking on timestamp in comments.
  • 3 Fixed error while clicking on go back button from reply in comments.

Resolves #587 #700

Checklist before requesting a review

  • [x] I have performed a self-review of my code
  • [x] I assure there is no similar/duplicate pull request regarding same issue

OLD

replyError.webm

NEW

replyErrorNew.webm

mvp5464 avatar May 13 '24 07:05 mvp5464

@hkirat Can you merge this, I am working on one feature I need this to be fixed first.

yash-kh avatar May 23 '24 09:05 yash-kh

@mvp5464 Thank, tested it working fine. Merging it now, for the bounty you must wait. I will be submitting it, if it satisfies bounty requirements you will receive it :)

siinghd avatar Jun 15 '24 15:06 siinghd

@mvp5464 if you want you can also fix the multiple comments if you click the comment button quickly

siinghd avatar Jun 15 '24 15:06 siinghd

@mvp5464 if you want you can also fix the multiple comments if you click the comment button quickly

started working on it now.

mvp5464 avatar Jun 15 '24 17:06 mvp5464

@siinghd , There is an error while commenting , reverted all the changes from this PR still error persists , solving it

Screenshot from 2024-06-15 23-25-03

mvp5464 avatar Jun 15 '24 19:06 mvp5464

@siinghd , There is an error while commenting , reverted all the changes from this PR still error persists , solving it

Screenshot from 2024-06-15 23-25-03

Strange, tested it on local and was working fine

siinghd avatar Jun 15 '24 19:06 siinghd

@siinghd , There is an error while commenting , reverted all the changes from this PR still error persists , solving it

Screenshot from 2024-06-15 23-25-03

Strange, tested it on local and was working fine

Error is specific to my machine, didn't figured out the problem yet but using incognito works so creating a new PR for duplicate comment

mvp5464 avatar Jun 16 '24 05:06 mvp5464