cms icon indicating copy to clipboard operation
cms copied to clipboard
verified publisher icon code100x

feat: add Youtube Renderer in VideoPlayer

Open VK-RED opened this issue 1 year ago • 2 comments

PR Fixes:

  • 1 Added Support for Youtube Videos.
  • 2 Added Youtube Renderer Component in VideoPlayer

Resolves #435

Screencast

Screencast from 18-04-24 07:11:10 PM IST.webm

Checklist before requesting a review

  • I have performed a self-review of my code
  • I assure there is no similar/duplicate pull request regarding same issue

VK-RED avatar Apr 18 '24 14:04 VK-RED

@VK-RED this should be already solved by #438 I wouldnt touch videoplayer component for this as that component have many things going on only for videojs. There are also keybinding and etc...

siinghd avatar Apr 18 '24 16:04 siinghd

Hey @siinghd , since Kirat mentioned he wanted Youtube Renderer in Video Player I decided to go with this. Also we don't render the default videojs when the link is of YouTube type and the keybindings will not be affected. Moreover I just wanted to get my hands dirty and learn something new, so I created this PR !!

VK-RED avatar Apr 18 '24 17:04 VK-RED

/bounty $25

hkirat avatar Apr 20 '24 16:04 hkirat