cms icon indicating copy to clipboard operation
cms copied to clipboard

Published 20 hours ago • verified publisher icon code100x

Fix: added youtube support

Open siinghd opened this issue 10 months ago • 4 comments

PR Fixes:

  • #435

Added support to youtube. It checks if the source.src is youtube url, if so it does render an Iframe containing the youtube video

Checklist before requesting a review

  • [x] I have performed a self-review of my code
  • [x] I assure there is no similar/duplicate pull request regarding same issue
  • [x] I assure that the build works locally

siinghd avatar Apr 16 '24 15:04 siinghd

This also contains PR #436

siinghd avatar Apr 16 '24 15:04 siinghd

Diff seems huge whatsup with that

hkirat avatar Apr 16 '24 20:04 hkirat

Diff seems huge whatsup with that

I checked out from #436 thats why, for only YouTube should be just few lines. It should be : src/components/admin/ContentRendererClient.tsx only

siinghd avatar Apr 17 '24 08:04 siinghd

@hkirat i think it can be merged safely, mostly its just the new part, it’s a tiny discussion portal

siinghd avatar Apr 17 '24 08:04 siinghd

Closing, it's done by #461

siinghd avatar Apr 20 '24 18:04 siinghd