cms icon indicating copy to clipboard operation
cms copied to clipboard

fix: add exact check for language and kind, referring docs

Open asharma991 opened this issue 1 year ago • 1 comments

PR Fixes:

  • Referred exact check for language and kind then only performing show/hide operation for subtitles.
  • https://videojs.com/guides/text-tracks/#showing-tracks-programmatically. I could've used forEach but TextTrackList doesn't seem to have that method https://developer.mozilla.org/en-US/docs/Web/API/TextTrackList#instance_properties

Resolves #297

Checklist before requesting a review

  • [x] I have performed a self-review of my code
  • [x] I assure there is no similar/duplicate pull request regarding same issue

asharma991 avatar Apr 02 '24 20:04 asharma991

Hey @hkirat, can we merge this?

asharma991 avatar Apr 28 '24 05:04 asharma991

closing https://github.com/code100x/cms/pull/298

siinghd avatar Jun 19 '24 22:06 siinghd

Hi @siinghd, may I know why was this closed? This is an improvement that we need, as in #298 it was not done in the correct manner as per the docs.

asharma991 avatar Jun 20 '24 17:06 asharma991

Hi @siinghd, may I know why was this closed? This is an improvement that we need, as in #298 it was not done in the correct manner as per the docs.

@hkirat ser, this is an essential change according to the videojs docs. I don't want to iterate this again but this won't work properly for the use cases where subs are not the first item.

asharma991 avatar Jul 04 '24 18:07 asharma991

@asharma991 I closed this because we will have only one track atm and it will be english, honestly its a very small change let me think about it.

also

i closed because of this https://github.com/code100x/cms/pull/298 ... because we have only one track

siinghd avatar Jul 04 '24 18:07 siinghd

@asharma991 I closed this because we will have only one track atm and it will be english, honestly its a very small change let me think about it.

also

i closed because of this #298 ... because we have only one track

Got it, but still we were not checking the kind in the first change and that's my bad. This is me cleaning up my own mess. Please think about it (:

asharma991 avatar Jul 04 '24 18:07 asharma991

Thanks for this @siinghd

asharma991 avatar Jul 04 '24 19:07 asharma991