cms icon indicating copy to clipboard operation
cms copied to clipboard

Published 20 hours ago • verified publisher icon code100x

migrated from npm to yarn

Open rohithreddy009 opened this issue 3 months ago • 10 comments

PR Fixes:

  • 1 fixes #312

Resolves #[312]

Checklist before requesting a review

  • [ ] I have performed a self-review of my code
  • [ ] I assure there is no similar/duplicate pull request regarding same issue
  • [ ] migrated from npm to yarn using yarn official docs https://classic.yarnpkg.com/lang/en/docs/migrating-from-npm/
  • [ ] changed readme.md file to setup the project using yarn
  • [ ] changed the docker file to use yarn instead of npm
  • [ ] ensured everything is working perfect in local development Screenshot 2024-04-02 at 3 03 05 PM

https://github.com/code100x/cms/assets/89250524/81d932eb-d49b-4c21-b570-5fec4f9aec0e

Screenshot 2024-04-02 at 2 31 07 PM

rohithreddy009 avatar Apr 02 '24 11:04 rohithreddy009

@hkirat sir, done migrating from npm to yarn. If anything is missing let me know

rohithreddy009 avatar Apr 02 '24 11:04 rohithreddy009

I have only changed Dockerfile, README file for stating how to setup the project locally using yarn to contributors, deleted package-lock.json and pnpm-lock.yaml

The changes in the other components are autoformatted by prettier, I haven't done any manual changes

rohithreddy009 avatar Apr 02 '24 11:04 rohithreddy009

Hey @rohithreddy009, I just wanted to know how much time does the yarn command takes to install all the dependencies locally ?

ssk090 avatar Apr 03 '24 11:04 ssk090

Hey @rohithreddy009, I just wanted to know how much time does the yarn command takes to install all the dependencies locally ?

Depends on your internet. For me 3-5 minutes. I'm on 100mbps internet.

rohithreddy009 avatar Apr 03 '24 12:04 rohithreddy009

@rohithreddy009 that's too long. It happens mostly under 30s if the lock file is maintained regularly

devsargam avatar Apr 03 '24 12:04 devsargam

I'm saying, if you forked the repo and downloading packages for the first time.

rohithreddy009 avatar Apr 03 '24 13:04 rohithreddy009

I'm saying, if you forked the repo and downloading packages for the first time.

https://github.com/rohithreddy009/cms/pull/1 check this PR

Results: image

ssk090 avatar Apr 03 '24 17:04 ssk090

Do we really need to move from npm to yarn atm? 👀

Neon-20 avatar Apr 05 '24 21:04 Neon-20

Do we really need to move from npm to yarn atm? 👀

I think this is the correct time to migrate, yarn has many advantages and faster than npm. If this is prolonged it becomes more complicated in the coming cycles. Moreover no big organization is usign npm as its package manager. vercel, dub used pnpm, calcom uses yarn as their package managers.

rohithreddy009 avatar Apr 06 '24 03:04 rohithreddy009

just two comments then good to go

Good to go ser
I tested changes locally.

rohithreddy009 avatar Apr 11 '24 13:04 rohithreddy009