cms icon indicating copy to clipboard operation
cms copied to clipboard

bug: submit button does not get disabled when using autofill in Firefox

Open fyzanshaik opened this issue 1 year ago • 3 comments

Describe the Bug
The submit button does not get disabled when using autofill in Firefox, even though it works correctly in other browsers.

To Reproduce
Steps to reproduce the behavior:

  1. Open the application in Firefox.
  2. Use the browser's autofill feature to fill the email and password fields.
  3. Observe that the submit button remains enabled even if the fields are valid.

Expected Behavior
The submit button should be disabled until all required fields are manually or autofill-populated and validated.

Screenshots or GIFs
Screenshot From 2024-12-12 17-53-08

Info (Please Complete the Following Information):

  • Browser: Firefox
  • Version: [118.0]

Additional Context
This issue is specific to Firefox's handling of autofill events. The autofill detection logic in the code does not properly update the state in Firefox, resulting in incorrect button behavior.

fyzanshaik avatar Dec 12 '24 12:12 fyzanshaik

fixed https://github.com/code100x/cms/pull/1651

fyzanshaik avatar Dec 12 '24 12:12 fyzanshaik

is this open?? i wantto contribute

himanshukandari14 avatar Jan 23 '25 23:01 himanshukandari14

is this open?? i wantto contribute

Check pr 1651 I fixed it already, you can review the PR and make your own changes if you find any bugs

fyzanshaik avatar Jan 25 '25 20:01 fyzanshaik