cms
cms copied to clipboard
Video reloads when we click on quality button even if the quality is same
Screencast from 03-03-24 11:31:28 AM IST.webm When you are watching videos say on 1080p on the website and in the quality list if we select 1080p it reloads, but it should not. Please assign this issue to me, i am part of your 0-100 cohort2; i have found the files from where this issue can be solved.
Whoever is solving this please attach the video selectors to the video player and remove the buttons we have created on the side
Whoever is solving this please attach the video selectors to the video player and remove the buttons we have created on the side
@hkirat - 2 clarifying questions on this:
- did you mean these quality control buttons should be removed ? HD - (1080p, 480p & 360p)
-
attach the video selectors to the video player
- Does that mean auto-selecting the video quality based on the user's screen viewport ?
Hey @hkirat, as per my understanding do you mean -
- Delete the
QualitySelector
andQualitySelectorControllBar
- Appending the video selectors to video player using some package like
@silvermine/videojs-quality-selector
- Then provide video quality source:
Either using <source>
<video id="video_1" class="video-js vjs-default-skin" controls preload="auto" width="640" height="268">
<source src="https://example.com/video_720.mp4" type="video/mp4" label="720P">
<source src="https://example.com/video_480.mp4" type="video/mp4" label="480P" selected="true">
<source src="https://example.com/video_360.mp4" type="video/mp4" label="360P">
</video>
Or using player.src()
player.src([
{
src: 'https://example.com/video_720.mp4',
type: 'video/mp4',
label: '720P',
},
{
src: 'https://example.com/video_480.mp4',
type: 'video/mp4',
label: '480P',
selected: true,
},
{
src: 'https://example.com/video_360.mp4',
type: 'video/mp4',
label: '360P',
},
]);
If the idea is correct, could you please assign the task. If not, please clarify.
Hey, can you assign this issue to me.
Hey, can you assign this issue to me.
It's already resolved by https://github.com/code100x/cms/pull/220
Why this issue isn't close ? and also labelled with bounty. If there any job left here, plz provide context So ppl can resolve it or else maintainers can close it.