cms icon indicating copy to clipboard operation
cms copied to clipboard

Video reloads when we click on quality button even if the quality is same

Open Dushyantbha012 opened this issue 11 months ago • 5 comments

Screencast from 03-03-24 11:31:28 AM IST.webm When you are watching videos say on 1080p on the website and in the quality list if we select 1080p it reloads, but it should not. Please assign this issue to me, i am part of your 0-100 cohort2; i have found the files from where this issue can be solved.

Dushyantbha012 avatar Mar 03 '24 06:03 Dushyantbha012

Whoever is solving this please attach the video selectors to the video player and remove the buttons we have created on the side

hkirat avatar Mar 12 '24 06:03 hkirat

Whoever is solving this please attach the video selectors to the video player and remove the buttons we have created on the side

@hkirat - 2 clarifying questions on this:

  1. did you mean these quality control buttons should be removed ? HD - (1080p, 480p & 360p)

Screenshot 2024-03-12 at 1 32 05 PM

  1. attach the video selectors to the video player - Does that mean auto-selecting the video quality based on the user's screen viewport ?

aadeshkulkarni avatar Mar 12 '24 08:03 aadeshkulkarni

Hey @hkirat, as per my understanding do you mean -

  1. Delete the QualitySelector and QualitySelectorControllBar
  2. Appending the video selectors to video player using some package like @silvermine/videojs-quality-selector
  3. Then provide video quality source:

Either using <source>

<video id="video_1" class="video-js vjs-default-skin" controls preload="auto" width="640" height="268">
   <source src="https://example.com/video_720.mp4" type="video/mp4" label="720P">
   <source src="https://example.com/video_480.mp4" type="video/mp4" label="480P" selected="true">
   <source src="https://example.com/video_360.mp4" type="video/mp4" label="360P">
</video>

Or using player.src()

player.src([
   {
      src: 'https://example.com/video_720.mp4',
      type: 'video/mp4',
      label: '720P',
   },
   {
      src: 'https://example.com/video_480.mp4',
      type: 'video/mp4',
      label: '480P',
      selected: true,
   },
   {
      src: 'https://example.com/video_360.mp4',
      type: 'video/mp4',
      label: '360P',
   },
]);

If the idea is correct, could you please assign the task. If not, please clarify.

adarsh-mamgain avatar Mar 12 '24 19:03 adarsh-mamgain

Hey, can you assign this issue to me.

Deepak1649 avatar Mar 21 '24 17:03 Deepak1649

Hey, can you assign this issue to me.

It's already resolved by https://github.com/code100x/cms/pull/220

nimit9 avatar Mar 21 '24 18:03 nimit9

Why this issue isn't close ? and also labelled with bounty. If there any job left here, plz provide context So ppl can resolve it or else maintainers can close it.

Nitin6404 avatar Aug 30 '24 03:08 Nitin6404