cms icon indicating copy to clipboard operation
cms copied to clipboard

feat: connect the questions to the video

Open ezhil56x opened this issue 1 year ago • 6 comments

PR Fixes: #862

Covered all the features proposed in the issue

Linking Questions to Videos

  • While creating a new question users can link a lecture video to it
  • Users can either search for a video or select one from a searchable dropdown menu
  • This feature should be optional, as we still want to allow questions without associated videos.
  • Users can view all questions related to a particular lecture video

Video Integration

  • Each video should have a button that, when clicked, redirects the user to all questions related to that video.

Database Changes

  • Add an optional video_id field to the question table to store the associated video ID.

https://github.com/user-attachments/assets/86248d72-8964-4a7c-8eb8-f2a201b846ce

Resolves #862

Checklist before requesting a review

  • [x] I have performed a self-review of my code
  • [x] I assure there is no similar/duplicate pull request regarding same issue

ezhil56x avatar Sep 27 '24 21:09 ezhil56x

@siinghd can u look at it in case you are free?

devsargam avatar Sep 30 '24 13:09 devsargam

@ezhil56x looks really good, lets just add two things

one minute 1:03 when i click on ask question button it open the modal thats really good! lets add another query parameter, &fromvideo=videoid... this way when the modal opens the video is already there and the user doesnt have to search

Second: the questions page lets add the possibility to filter questions based on a specific video... maybe add a same search dropdown and when user selects the video only that questions appear

siinghd avatar Oct 04 '24 23:10 siinghd

also fix merge conflicts

siinghd avatar Oct 04 '24 23:10 siinghd

@siinghd Updated my PR with the requested changes

https://github.com/user-attachments/assets/2251c4d4-16da-48d9-9dda-046a7296acb7

ezhil56x avatar Oct 05 '24 22:10 ezhil56x

@siinghd for rereview

devsargam avatar Oct 08 '24 21:10 devsargam

Resolved conflicts. Hoping it to get merged at the earliest to avoid further conflicts.

ezhil56x avatar Oct 09 '24 09:10 ezhil56x

hey @devsargam could you please ask Singh Bro to review this one. It's being stalled from a long time. PR looks amazing.

mrpaaradox avatar Oct 25 '24 11:10 mrpaaradox

@avparadox thinking of removing the questions endpoint totally since it is causing many conflicts are not a lot of people are using it a lot

devsargam avatar Oct 25 '24 11:10 devsargam

Maybe we can ask Kirat bro if he wish to take a Quick QnA before every class. If he agrees to it, then maybe PR makes a sense or else I believe it is good to be removed.

mrpaaradox avatar Oct 25 '24 11:10 mrpaaradox

I asked him and he agreed it could be removed but I really like the idea of reading questions present in the QnA area

devsargam avatar Oct 25 '24 11:10 devsargam

Even I liked the QnA page. If people interact, a lot of good content can be seeded like Stackoverflow. But as a dev, we can't control the engagement things. Probably you can declare this as closed.

The guy who made this PR, I salute him 🫡. He have done justice to the issue. I probably can't make such a good PR right now. He has done a commendable job 🙌🏻

Thanke @ezhil56x 👏🏻

mrpaaradox avatar Oct 25 '24 11:10 mrpaaradox

@avparadox I agree. @ezhil56x can you give me your upi address I will at least transfer some amount for the effort. Sorry but I can't merge this right now but this is great.

devsargam avatar Nov 17 '24 04:11 devsargam