refactor(nx-plugin): explicit import extensions [DO NOT MERGE]

[matejchalk]

[github-actions[bot]]

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared current commit 4bacdaa925efff9829d8c4ba2921fcae8e82484e with previous commit c677fa25e8d9fd3cb4a58d42674b9f1ff5a5cf88.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Categories

🏷️ Category	⭐ Previous score	⭐ Current score	🔄 Score change
Performance	🟡 55	🔴 50
Code coverage	🟢 91	🟢 90
Documentation	🔴 23	🔴 23
Security	🟡 75	🟡 75	–
Updates	🟡 77	🟡 77	–
Accessibility	🟢 92	🟢 92	–
Best Practices	🟢 100	🟢 100	–
SEO	🟡 61	🟡 61	–
Bug prevention	🟢 100	🟢 100	–
Code style	🟢 100	🟢 100	–

👎 3 groups regressed, 👍 1 audit improved, 👎 9 audits regressed, 10 audits changed without impacting score

🗃️ Groups

🔌 Plugin	🗃️ Group	⭐ Previous score	⭐ Current score	🔄 Score change
Lighthouse	Performance	🟡 55	🔴 50
Code coverage	Code coverage metrics	🟢 91	🟢 90
JSDoc coverage	Documentation coverage	🔴 23	🔴 23

15 other groups are unchanged.

🛡️ Audits

🔌 Plugin	🛡️ Audit	📏 Previous value	📏 Current value	🔄 Value change
Lighthouse	Speed Index	🟨 4.8 s	🟥 7.7 s
Lighthouse	Time to Interactive	🟥 12.7 s	🟥 17.5 s
Lighthouse	Total Blocking Time	🟥 2,590 ms	🟥 9,530 ms
Lighthouse	Largest Contentful Paint	🟨 3.5 s	🟨 3.4 s
Lighthouse	First Contentful Paint	🟨 2.8 s	🟨 2.8 s
Code coverage	Function coverage	🟩 93 %	🟩 92.8 %
Code coverage	Line coverage	🟨 90 %	🟨 89.8 %
Code coverage	Branch coverage	🟨 85.9 %	🟨 85.8 %
JSDoc coverage	Types coverage	🟥 210 undocumented types	🟥 212 undocumented types
JSDoc coverage	Functions coverage	🟥 451 undocumented functions	🟥 452 undocumented functions
Lighthouse	Minimizes main-thread work	🟥 11.8 s	🟥 24.0 s
Lighthouse	JavaScript execution time	🟥 6.1 s	🟥 10.8 s
Lighthouse	Metrics	🟩 100%	🟩 100%
Lighthouse	Avoids enormous network payloads	🟩 Total size was 1,828 KiB	🟩 Total size was 1,832 KiB
Lighthouse	Max Potential First Input Delay	🟥 1,850 ms	🟥 3,410 ms
Lighthouse	Uses efficient cache policy on static assets	🟨 27 resources found	🟨 27 resources found
Lighthouse	Initial server response time was short	🟩 Root document took 440 ms	🟩 Root document took 360 ms
Lighthouse	Eliminate render-blocking resources	🟥 Potential savings of 810 ms	🟥 Potential savings of 800 ms
Lighthouse	Network Round Trip Times	🟩 20 ms	🟩 20 ms
Lighthouse	Server Backend Latencies	🟩 120 ms	🟩 120 ms

576 other audits are unchanged.

[BioPhoton]

@matejchalk we ran into the same error. What was the fix to not remove .js from all imports?

[matejchalk]

we ran into the same error. What was the fix to not remove .js from all imports?

It's been a while, so I don't really remember the context. What's the error you're getting? Looks like in ba918503a2216d3b89f943f01893d1a34eaf2812 I just added .js extension to all imports in nx-plugin (compatible with both CJS and ESM) to check that all tests pass, so I don't think I encountered any errors.