cli icon indicating copy to clipboard operation
cli copied to clipboard

feat: nx-plugin with v2 format

Open aramirezj opened this issue 8 months ago โ€ข 4 comments

closes #881

aramirezj avatar Mar 09 '25 20:03 aramirezj

Code PushUp

๐Ÿคจ Code PushUp report has both improvements and regressions โ€“ compared current commit b03db634a6fa90f155a337fdf0cab8a77147d0f3 with previous commit b03db634a6fa90f155a337fdf0cab8a77147d0f3.

๐Ÿท๏ธ Categories

๐Ÿท๏ธ Category โญ Previous score โญ Current score ๐Ÿ”„ Score change
Performance ๐ŸŸก 51 ๐Ÿ”ด 47 โ†“ โˆ’3.2
Code coverage ๐ŸŸข 90 ๐ŸŸข 90 โ€“
Security ๐ŸŸก 67 ๐ŸŸก 67 โ€“
Updates ๐ŸŸก 81 ๐ŸŸก 81 โ€“
Accessibility ๐ŸŸข 92 ๐ŸŸข 92 โ€“
Best Practices ๐ŸŸข 100 ๐ŸŸข 100 โ€“
SEO ๐ŸŸก 61 ๐ŸŸก 61 โ€“
Bug prevention ๐ŸŸข 100 ๐ŸŸข 100 โ€“
Code style ๐ŸŸข 100 ๐ŸŸข 100 โ€“
Documentation ๐Ÿ”ด 23 ๐Ÿ”ด 23 โ€“
๐Ÿ‘Ž 1 group regressed, ๐Ÿ‘ 2 audits improved, ๐Ÿ‘Ž 3 audits regressed, 10 audits changed without impacting score

๐Ÿ—ƒ๏ธ Groups

๐Ÿ”Œ Plugin ๐Ÿ—ƒ๏ธ Group โญ Previous score โญ Current score ๐Ÿ”„ Score change
Lighthouse Performance ๐ŸŸก 51 ๐Ÿ”ด 47 โ†“ โˆ’3.2

17 other groups are unchanged.

๐Ÿ›ก๏ธ Audits

๐Ÿ”Œ Plugin ๐Ÿ›ก๏ธ Audit ๐Ÿ“ Previous value ๐Ÿ“ Current value ๐Ÿ”„ Value change
Lighthouse Speed Index ๐ŸŸจ 5.3ย s ๐ŸŸฅ 7.0ย s โ†‘ +32.6โ€‰%
Lighthouse Time to Interactive ๐ŸŸฅ 12.0ย s ๐ŸŸฅ 14.0ย s โ†‘ +17.5โ€‰%
Lighthouse Total Blocking Time ๐ŸŸฅ 2,310ย ms ๐ŸŸฅ 6,290ย ms โ†‘ +172.1โ€‰%
Lighthouse First Contentful Paint ๐ŸŸฅ 3.0ย s ๐ŸŸจ 2.9ย s โ†“ โˆ’4.2โ€‰%
Lighthouse Largest Contentful Paint ๐ŸŸจ 3.8ย s ๐ŸŸจ 3.8ย s โ†“ โˆ’1.2โ€‰%
Lighthouse Minimizes main-thread work ๐ŸŸฅ 11.5ย s ๐ŸŸฅ 19.5ย s โ†‘ +69.4โ€‰%
Lighthouse JavaScript execution time ๐ŸŸฅ 5.1ย s ๐ŸŸฅ 7.8ย s โ†‘ +53.7โ€‰%
Lighthouse Metrics ๐ŸŸฉ 100% ๐ŸŸฉ 100% โ†‘ +17.5โ€‰%
Lighthouse Max Potential First Input Delay ๐ŸŸฅ 1,370ย ms ๐ŸŸฅ 2,680ย ms โ†‘ +96.3โ€‰%
Lighthouse Eliminate render-blocking resources ๐ŸŸฅ Potential savings of 1,000ย ms ๐ŸŸฅ Potential savings of 490ย ms โ†“ โˆ’51.4โ€‰%
Lighthouse Uses efficient cache policy on static assets ๐ŸŸจ 27 resources found ๐ŸŸจ 27 resources found โ†“ โˆ’0.1โ€‰%
Lighthouse Server Backend Latencies ๐ŸŸฉ 180ย ms ๐ŸŸฉ 230ย ms โ†‘ +26.7โ€‰%
Lighthouse Initial server response time was short ๐ŸŸฉ Root document took 380ย ms ๐ŸŸฉ Root document took 400ย ms โ†‘ +6.8โ€‰%
Lighthouse Avoids enormous network payloads ๐ŸŸฉ Total size was 1,832ย KiB ๐ŸŸฉ Total size was 1,832ย KiB โ†“ โˆ’0.1โ€‰%
Lighthouse Network Round Trip Times ๐ŸŸฉ 60ย ms ๐ŸŸฉ 60ย ms โ†“ โˆ’2.4โ€‰%

581 other audits are unchanged.

github-actions[bot] avatar Mar 09 '25 21:03 github-actions[bot]

From what I understood we are keeping both legacy and V2 for backwards compatibility.

Looks good so far, I'll watch this as this is now to only blocker for moving to latest Nx. It will also unlock latest vitest which I'm looking forward updating to ๐Ÿ‘๐Ÿป

vmasek avatar Mar 10 '25 13:03 vmasek

From what I understood we are keeping both legacy and V2 for backwards compatibility.

Looks good so far, I'll watch this as this is now to only blocker for moving to latest Nx. It will also unlock latest vitest which I'm looking forward updating to ๐Ÿ‘๐Ÿป

There is one thing left and that is considering projec.json AND package.json

BioPhoton avatar Mar 10 '25 16:03 BioPhoton

All done! Ready to review again

aramirezj avatar Mar 23 '25 09:03 aramirezj