cli icon indicating copy to clipboard operation
cli copied to clipboard

Js Package Analyzer doesn't ignore exit code on yarn-modern package manager

Open meljishi opened this issue 1 year ago • 2 comments

What happened?

As commented on the slack channel, after using the javascript plugin with yarn v4 we couldn't make our runner work. The yarn audit command errors out when a dependency with a critical or high issue arises and the plugin doesn't ignore the exit code Image

What would you expect to happen?

The plugin wrapper should only read the generated report and push it to the portal. Only should report an error when the process itselft crashes, not when the audit reports a critical issue.

What steps did you take?

Just run the analysis

Code PushUp package version

@code-pushup/[email protected]

What operation system are you on?

Linux

Node version

No response

Relevant log output

No response

meljishi avatar Oct 11 '24 14:10 meljishi

@meljishi We shipped a fix for this a few weeks ago in version 0.55.0 (#878). Could you check if this resolves your issue?

matejchalk avatar Dec 19 '24 12:12 matejchalk

I will have a look into this. Thank you very much

El 19 dic 2024, a las 13:49, Matěj Chalk @.***> escribió:

@meljishi https://github.com/meljishi We shipped a fix for this a few weeks ago in version 0.55.0 (#878 https://github.com/code-pushup/cli/pull/878). Could you check if this resolves your issue?

— Reply to this email directly, view it on GitHub https://github.com/code-pushup/cli/issues/836#issuecomment-2553771831, or unsubscribe https://github.com/notifications/unsubscribe-auth/BKD6BLEK23CJJQJHLZ2TS6T2GK6FLAVCNFSM6AAAAABPZDCNSCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNJTG43TCOBTGE. You are receiving this because you were mentioned.

Manel Eljishi SysOps Engineer

UFirst Group +34 96 013 00 70 · @.*** C/Almirante Cadarso 26 · 46005 Valencia · Spain

https://www.ufirstgroup.com/en/expertise/e-commerce/data-firsthttps://www.ufirstgroup.com/en/expertise/e-commerce/data-first  https://www.ufirstgroup.com/en/Q https://www.ufirstgroup.com/expertise/data-firstUALITY DATA FOR THE COMPETITIVE EDGE – www.ufirstgroup.ch http://www.ufirstgroup.ch/

meljishi avatar Dec 19 '24 12:12 meljishi

@meljishi I'm gonna assume the issue is resolved. Let me know if that's not the case.

matejchalk avatar Sep 26 '25 08:09 matejchalk