invoker icon indicating copy to clipboard operation
invoker copied to clipboard

RubyDNS 2.0.0 available

Open ioquatix opened this issue 9 years ago • 8 comments

This update is a big improvement to stability, if you have time to try it out and report any issues that would be great.

It might also assist with the IPv6 issue, since that wasn't previously supported by event machine which is no longer used.

ioquatix avatar Apr 09 '17 15:04 ioquatix

I will try it out locally next week and let you know @ioquatix . Thanks for new release 👍

iffyuva avatar Apr 09 '17 16:04 iffyuva

hi @ioquatix , I tried new rc1 release gem, and am facing this issue

/Users/yuva/.rvm/gems/ruby-2.4.1/gems/async-dns-0.10.0/lib/async/dns/handler.rb:137:in `run': unknown keyword: listen (ArgumentError)
	from /Users/yuva/.rvm/gems/ruby-2.4.1/gems/async-dns-0.10.0/lib/async/dns/server.rb:112:in `block (2 levels) in run'
	from /Users/yuva/.rvm/gems/ruby-2.4.1/gems/async-dns-0.10.0/lib/async/dns/server.rb:111:in `each'
	from /Users/yuva/.rvm/gems/ruby-2.4.1/gems/async-dns-0.10.0/lib/async/dns/server.rb:111:in `block in run'
	from /Users/yuva/.rvm/gems/ruby-2.4.1/gems/async-0.12.0/lib/async/task.rb:70:in `block in initialize'

Any idea whats the issue? Thanks.

iffyuva avatar Apr 17 '17 06:04 iffyuva

Do you mind sharing the code you are using to setup RubyDNS?

ioquatix avatar Apr 17 '17 06:04 ioquatix

Its here https://github.com/code-mancers/invoker/blob/425a5d71d/lib/invoker/power/dns.rb @ioquatix

iffyuva avatar Apr 17 '17 07:04 iffyuva

The problem is here: https://github.com/code-mancers/invoker/blob/425a5d71dd9fc19d7119d9886f6715d6b4c72305/lib/invoker/power/powerup.rb#L17

You need to remove listen: DNS.server_ports. You can either add it to the new or directly set it up in DNS#initialize.

Additionally, it won't work inside EventMachine, but it will work absolutely fine on it's own thread, and will be just as efficient since it's also using asynchronous io.

ioquatix avatar Apr 17 '17 07:04 ioquatix

See https://github.com/socketry/async-dns/blob/master/lib/async/dns/server.rb#L39 for how to call super.

ioquatix avatar Apr 17 '17 07:04 ioquatix

Thanks for pointers @ioquatix . I don't know much internals of invoker. I will figure out when I find time.

iffyuva avatar Apr 17 '17 07:04 iffyuva

I've just released RubyDNS 2.0.0.

Please consider updating and let me know any feedback. Thanks.

The main user visible change between rc and 2.0.0 was that the listen: option was replaced by simply suppling as the first argument.

ioquatix avatar Jul 30 '17 12:07 ioquatix