invoicing TimeDependent belongs_to replaced_by association should be optional for rails5.2

TimeDependent belongs_to replaced_by association should be optional for rails5.2

Open weber-s opened this issue 4 years ago • 2 comments

With the rails 5 update, belongs_to association are require by default.

When trying to upgrade a rails 4 to rails 5 app with invoicing, InvoicingTaxRate failed due to this issue.

I think this PR fix it.

It should also fix #58

Oct 02 '20 12:10 weber-s

I don't fully understand why the test are failling for only 2 Gemfiles. Is it specific to this PR (i.e. did I introduce a bug) or already present ?

Nov 07 '20 16:11 weber-s

The merge of the other PR #80 fix the travis CI. Is it possible to merge it upstream and release it on rubygems?

Jan 17 '21 15:01 weber-s