doctum icon indicating copy to clipboard operation
doctum copied to clipboard

fix: loop over forward slashes for relative dir, replace after urlencode

Open tiller1010 opened this issue 2 years ago • 2 comments

Fixes #63

  • Loops over forward slashes for "../" relative path.
  • Replaces URL-encoded forward slashes with the original slash.

tiller1010 avatar Jan 10 '24 21:01 tiller1010

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (78ee960) 63.99% compared to head (120ef45) 63.99%.

Additional details and impacted files
@@            Coverage Diff            @@
##             v5.5.x      #64   +/-   ##
=========================================
  Coverage     63.99%   63.99%           
  Complexity     1252     1252           
=========================================
  Files            53       53           
  Lines          3611     3611           
=========================================
  Hits           2311     2311           
  Misses         1300     1300           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jan 11 '24 09:01 codecov[bot]

Update: I am a bit unsatisfied about the current code, maybe I will refactor it a bit before merging this We should not have to split the path and re build it, it feels wrong

williamdes avatar Apr 06 '24 12:04 williamdes