codehike icon indicating copy to clipboard operation
codehike copied to clipboard

Callout example not working for language fsharp/fs

Open jannikbuschke opened this issue 1 year ago • 2 comments

example: https://stackblitz.com/edit/github-wxcn1t?file=app%2Fpage.mdx

thanks for this awesome work!, looking forward to use it

jannikbuschke avatar Jun 09 '24 18:06 jannikbuschke

interesting, thanks for the repro

pomber avatar Jun 10 '24 11:06 pomber

Hello 👋🏻

Neither it seems to be parsing any annotations for graphql blocks

```graphql
# !callout[/id/] This is a callout
query foo {
  foo { id }
}
```

EDIT: same for markdown

ogizanagi avatar Jul 04 '24 15:07 ogizanagi

Thanks. Both are probably issues with https://github.com/code-hike/lighter. I need to make some changes there soon, so I'll make sure to fix this too.

pomber avatar Jul 11 '24 08:07 pomber

rust also failing

```rust
// !mark(1:2)
fn main() {
    let s1 = String::from("hello");
    let s2 = s1;

    println!("{}", s1);
    println!("{}", s2);
}
```

From https://github.com/code-hike/v1/issues/14

pomber avatar Jul 12 '24 09:07 pomber

Should be fixed in v1.0.0-beta.2

pomber avatar Jul 13 '24 12:07 pomber

Confirmed for fsharp/fs 🎉

jannikbuschke avatar Jul 14 '24 19:07 jannikbuschke

Confirmed for graphql as well 👌🏻 (for markdown, though, I had some other errors during the upgrade, so it might need further inspections)

ogizanagi avatar Jul 15 '24 07:07 ogizanagi