NC-COVID-Support icon indicating copy to clipboard operation
NC-COVID-Support copied to clipboard

Show only three buttons on mobile

Open jklafka opened this issue 4 years ago • 5 comments

Re: issue #259, I worked on the first part of this. On the mobile webpage, only the options to call the location, get directions or go to the website (if available) will show.

jklafka avatar Sep 12 '20 21:09 jklafka

Hey there! :wave: This repository uses the Prettier code style.

You forgot to format these files in your pull request:

  • covid-19-support/src/components/BusinessDetails.vue

The Prettier installation guide is a good place to get started with formatting your code properly. Thanks!!

:heart:

Your friendly Prettifier bot

ghost avatar Sep 12 '20 21:09 ghost

Hi @jklafka - Thank you for trying to take a look at this, unfortunately this is not quite what we have envisaged. We do want all the details to be viewable when a user pulls the card up from the bottom of the screen, so we don't actually want to hide the items on mobile.

If it's ok, I suggest we close this PR.

If you'd still like to try and help tackle it, perhaps we could have a call next week to discuss it?

readingdancer avatar Sep 25 '20 02:09 readingdancer

Sure, I'd be happy to talk about how to move forward on this next week. Do you have time next weekend to discuss it? And would you still like me to close this pull request?

jklafka avatar Sep 26 '20 20:09 jklafka

Hi @jklafka - Really sorry that this was not followed up back in September of last year, I was a bit overwhelmed with homeschooling two children and life in general that this project got sidelined by me and no one else too over the reigns. I am trying to bring it back to life, so I will try and take a look at your PR this week, however it may well be too conflicting with the other changes to merge in, we will have to see :)

readingdancer avatar Feb 01 '21 03:02 readingdancer

Absolutely, no problem. To be honest, I'm not familiar with Vue.js, so worries if you have to throw the PR out! Hope you can get back into this project soon.

jklafka avatar Feb 14 '21 18:02 jklafka