craft icon indicating copy to clipboard operation
craft copied to clipboard

Line coverage can vary slightly even with no code changes

Open joshlory opened this issue 8 years ago • 3 comments

PR https://github.com/code-dot-org/craft/pull/52 attempted to reduce variance in code coverage metrics due to random animation timing. This helped, but we're still seeing tiny variation in line coverage of animations in integration tests.

Creating this issue to track.

joshlory avatar Oct 04 '17 16:10 joshlory

Sample diff: https://codecov.io/gh/code-dot-org/craft/pull/174/src/src/js/game/Entities/Chicken.js

joshlory avatar Oct 04 '17 18:10 joshlory

Another: https://codecov.io/gh/code-dot-org/craft/pull/215/src/src/js/game/Entities/IronGolem.js

joshlory avatar Oct 05 '17 16:10 joshlory

https://codecov.io/gh/code-dot-org/craft/pull/243/src/src/js/game/Entities/IronGolem.js

joshlory avatar Oct 09 '17 20:10 joshlory