ember-stripe-elements icon indicating copy to clipboard operation
ember-stripe-elements copied to clipboard

Prefix actions with on* (eg onBlur)

Open josemarluedke opened this issue 6 years ago • 4 comments

It would be more idiomatic if the actions would be all prefixed with on*. For example: onBlur onChange, onComplete etc.

It is also confusing because of ember's component events names in the component class: https://guides.emberjs.com/release/components/handling-events/#toc_event-names

josemarluedke avatar Aug 01 '19 20:08 josemarluedke

+1 on this. I think however it makes sense to cut a release with where we're at now (think that will be 0.5), then make this change for the release after that?

lindyhopchris avatar Aug 02 '19 08:08 lindyhopchris

After #47 is merged, I can get a PR for this by adding a deprecation for the old way while keeping it working. You can release a version that has the deprecation, then we can remove that in a followup version.

josemarluedke avatar Aug 02 '19 15:08 josemarluedke

Sounds like a plan :-)

lindyhopchris avatar Aug 02 '19 15:08 lindyhopchris

@josemarluedke think we could probably do with a PR on this as it's starting to cause confusion (understandably!). Would you have time to do that at some point (not asking for it immediately, just wondering if you still have time in theory!)

lindyhopchris avatar Sep 05 '19 07:09 lindyhopchris