code-corps
added handling of parameters of stripev3.load
Coverage remained the same at 92.308% when pulling a2c44d9aa798e2d84fcb168d0e6d868d5d8d5af1 on caltabid:master into d0eb4639200a93333065f87ab175173be431eee1 on code-corps:master.
@caltabid thanks for the PR!
Are there any issues with the recent merges here? Would you mind rebasing and checking? Thank you!
@caltabid I see you've back merged develop into your branch. Think I therefore need to set the merge target as develop not master?
@lindyhopchris for my project I need both SCA modification introduced in develop and the possibility to handle options parameters in stripe.load introduced in my branch. The best would be to merge develop in the master along with my modifications. I also had some compatibility issues with ember 2.18 described in #65 can someone confirm this problem?
@caltabid totally understand. The develop branch has the SCA stuff on it... that's what I'm also using as I'm doing updates for SCA now too.
I'll change the target branch for this PR to develop. Understand about wanting to get it into master but we need to do that with a tagged release... which hopefully we'll get sorted. FYI in the meantime I'm tying my Ember apps to specific commit references on the develop branch as a work-around.
I'll take a look at #65 now.
@caltabid generally approach looks good and it'll be great to have these changes - so thanks for the PR. Have added some comments. Now that it's against the develop branch it's clear exactly what is being changed by this PR and I think it makes sense to keep the code changes solely focused on adding params to the load method.