code-corps-ember Update ember-cli-meta-tags to the latest version 🚀

Version 4.0.0 of ember-cli-meta-tags just got published.

Dependency	ember-cli-meta-tags
Current Version	3.1.0
Type	devDependency

The version 4.0.0 is not covered by your current version range.

Without accepting this pull request your project will work just like it did before. There might be a bunch of new features, fixes and perf improvements that the maintainers worked on for you though.

I recommend you look into these changes and try to get onto the latest version of ember-cli-meta-tags. Given that you have a decent test suite, a passing build is a strong indicator that you can take advantage of these changes by merging the proposed change into your project. Otherwise this branch is a great starting point for you to work on the update.

Commits

The new version differs by 6 commits.

299d6c9 4.0.0
85e54f2 Merge pull request #56 from cibernox/patch-1
597a455 Remove 1.13 from ember-try. Apparently it has been broken for a while already.
146208a Update readme
7e71d8b Update package.json
7c407e2 Update dependency on ember-cli-head

See the full diff

Not sure how things should work exactly?

There is a collection of frequently asked questions and of course you may always ask my humans.

Your Greenkeeper Bot :palm_tree:

Jun 06 '17 18:06 greenkeeper[bot]

This fails due to what seems to be a reported issue in the ember-cli-head subdependency:

https://github.com/ronco/ember-cli-head/issues/33

We should wait to see if there's any activity there before spending time trying to fix it here.

Jun 12 '17 09:06 begedin

@begedin I see headTags defined in application.js route. Also see those meta tags in index.html. Is there some duplication here or am I missing something?

Dec 09 '17 21:12 snewcomer

@begedin ping again on this question.

Dec 11 '17 19:12 joshsmith

@joshsmith @snewcomer

I'm not the one who worked on it initially, so I'm not sure. My guess would be, the index.html ones are the default to fall back on, while each route would end up dynamically setting their own.

We only do it in the app route right now, and from what I can tell, they're near-identical, to those in index.html, so technically, I guess we don't really need ember-cli-meta-tags yet, maybe.

We presumably would end up needing them eventually, though, since we'd like different tags on project pages, for example.

Dec 12 '17 06:12 begedin