code-corps-api icon indicating copy to clipboard operation
code-corps-api copied to clipboard

Published 20 hours ago • verified publisher icon code-corps

Error fetching_issue from GitHub API

Open joshsmith opened this issue 7 years ago • 3 comments

Problem

We had an error earlier fetching an issue with event ID e99b7a10-cbd6-11e7-9ebc-4752129e3313 at 11/17/2017 12:35:56.

The error data does not get passed along (we only log a %{}) and I'm not sure we actually send the error to Sentry.

Still not sure what caused it.

joshsmith avatar Nov 19 '17 01:11 joshsmith

In fact, we do try to send the error to Sentry, but incorrectly:

(CodeCorps.GitHub.Event.GitHubEventError) got %{} while retrieving Exception.message/1 for %CodeCorps.GitHub.Event.GitHubEventError{reason: %{}} (expected a string)

joshsmith avatar Nov 19 '17 01:11 joshsmith

From this point forward, we will actually capture the error in our DB, but the issue with passing the error along to Sentry is not fixed.

joshsmith avatar Dec 29 '17 23:12 joshsmith

We'll need to wait for this error to happen again or we can reason about what might have caused it.

Possible causes:

  • APIError
  • HTTPClientError
  • PaginationError
  • ???

joshsmith avatar Dec 29 '17 23:12 joshsmith